From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Fri, 20 Jul 2012 22:10:28 +0000 Subject: [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller In-Reply-To: <1342787373-2230-2-git-send-email-linux@prisktech.co.nz> References: <1342787373-2230-1-git-send-email-linux@prisktech.co.nz> <1342787373-2230-2-git-send-email-linux@prisktech.co.nz> Message-ID: <201207202210.28790.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 20 July 2012, Tony Prisk wrote: > Add support for a generic non-pci UHCI companion controller. > Existing board files for arch-vt8500 updated to include UHCI > support. > > Signed-off-by: Tony Prisk Looks almost good, but * please add a binding document * cc the maintainers and usb mailing list * the "of-uhci" string does not seem appropriate: > +static const struct of_device_id platform_uhci_ids[] = { > + { .compatible = "of-uhci", }, > + {} > +}; The of- part is clearly meaningless in the binding that is about of devices. Using usb-uhci would be more appropriate I think, but maybe someone can come up with an even better name. Which consortium or company created uhci? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCHv2 2/2] ARM: vt8500: Add support for UHCI companion controller Date: Fri, 20 Jul 2012 22:10:28 +0000 Message-ID: <201207202210.28790.arnd@arndb.de> References: <1342787373-2230-1-git-send-email-linux@prisktech.co.nz> <1342787373-2230-2-git-send-email-linux@prisktech.co.nz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1342787373-2230-2-git-send-email-linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Tony Prisk Cc: Greg Kroah-Hartman , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alan Stern , vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Friday 20 July 2012, Tony Prisk wrote: > Add support for a generic non-pci UHCI companion controller. > Existing board files for arch-vt8500 updated to include UHCI > support. > > Signed-off-by: Tony Prisk Looks almost good, but * please add a binding document * cc the maintainers and usb mailing list * the "of-uhci" string does not seem appropriate: > +static const struct of_device_id platform_uhci_ids[] = { > + { .compatible = "of-uhci", }, > + {} > +}; The of- part is clearly meaningless in the binding that is about of devices. Using usb-uhci would be more appropriate I think, but maybe someone can come up with an even better name. Which consortium or company created uhci? Arnd