All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jie Liu <jeff.liu@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Mark Tinguely <tinguely@sgi.com>,
	xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten extents
Date: Sun, 22 Jul 2012 02:28:30 -0400	[thread overview]
Message-ID: <20120722062830.GA23062@infradead.org> (raw)
In-Reply-To: <500B8FAA.8030804@oracle.com>

On Sun, Jul 22, 2012 at 01:29:14PM +0800, Jie Liu wrote:
> Should we keep 285 unchanged and introduce a new test 28? which is
> dedicated to ensuring the refinements works as expected?
> I have added some new test cases to Mark's test program yesterday,
> looks it will grow even bigger if I can think out some other
> corner cases(will send them to Mark).

I think a separate case is better, as 285 just tests a basic correct
implementation, while this one tests the refinements.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2012-07-22  6:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  8:28 [PATCH v4] xfs: probe data buffer from page cache for unwritten extents Jeff Liu
2012-07-20 18:46 ` Mark Tinguely
2012-07-21  6:24   ` Jie Liu
2012-07-22  4:57     ` Christoph Hellwig
2012-07-22  5:29       ` Jie Liu
2012-07-22  6:28         ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120722062830.GA23062@infradead.org \
    --to=hch@infradead.org \
    --cc=jeff.liu@oracle.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.