From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: shuahkhan@gmail.com, "Kim, Milo" <Milo.Kim@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] leds: add new lp8788 led driver
Date: Sun, 22 Jul 2012 19:19:56 +0100 [thread overview]
Message-ID: <20120722181956.GA4557@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAK5ve-JPtHkCMPV_UYUUZxrt_gzS3tsRXm5x8nFbB6hp+-gBxg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 567 bytes --]
On Sat, Jul 21, 2012 at 02:48:49AM +0800, Bryan Wu wrote:
> Actually cancel_work_sync() is quite similar to flush_work_sync()
> here. For the timer thing, in fact it is NULL when cancel_work_sync()
> call __cancel_work_timer().
> And Mark, do you have any advice about the flush_work_sync() and
> cancel_work_sync(). I saw you use flush in the
> drivers/leds/leds-wm8350.c.
If the work is flushed then the state that userspace thought was set
when the driver is removed will actually be set before the driver is
removed. This is fairly minor but might be useful.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-07-22 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 8:43 [PATCH v2] leds: add new lp8788 led driver Kim, Milo
2012-07-20 15:49 ` Shuah Khan
2012-07-20 18:48 ` Bryan Wu
2012-07-22 18:19 ` Mark Brown [this message]
2012-07-24 0:23 ` Bryan Wu
2012-07-24 12:55 ` Mark Brown
2012-07-25 4:46 ` Bryan Wu
2012-07-25 18:43 ` Mark Brown
2012-07-26 2:51 ` Bryan Wu
2012-08-01 20:35 ` Mark Brown
2012-07-20 16:23 ` devendra.aaru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120722181956.GA4557@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Milo.Kim@ti.com \
--cc=bryan.wu@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.