Re: [PATCH 6/7] compressed: rename barebox target to zbarebox and zbarebox.bin

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 08:35 Mon 23 Jul     , Sascha Hauer wrote:
> On Mon, Jul 23, 2012 at 06:26:02AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Today we link to whole barebox and rely on gcc to cleanup via it's garbage
> > collector.
> > Now we specify only what is needed and introduce a new directory with source
> > only related to the compressed target.
> > 
> > Build it in arch/<arm>/compressed
> > Rebuild all the needed object.
> > 
> > Keep the previous target untouched.
> > This fix the modules support and allow custom flags for each file.
> > 
> > Import string functions from linux 3.4 (arch/arm/boot/compressed/string.c) and
> > implement a dummy panic.
> 
> This does not work on all targets having a lowlevel init:
> 
> arch/arm/compressed/start.o: In function `reset':
> start.c:(.text_bare_init.text+0x28): undefined reference to `board_init_lowlevel'
> 
> Why don't we simply do this:
> 
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 647c536..12869b3 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -150,11 +150,9 @@ TEXT_BASE = $(CONFIG_TEXT_BASE)
>  
>  CPPFLAGS += -DTEXT_BASE=$(TEXT_BASE)
>  
> -ifndef CONFIG_MODULES
>  # Add cleanup flags
>  CPPFLAGS += -fdata-sections -ffunction-sections
>  LDFLAGS_barebox += -static --gc-sections
> -endif
you can not do this as this break modules

for board_init_lowlevel we need to add it to the decompressor

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox