From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jesper Juhl <jj@chaosbits.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Christopher Harrer <charrer@alacritech.com>,
linux-kernel@vger.kernel.org, Lior Dotan <liodot@gmail.com>
Subject: Re: [PATCH 1/2] Staging: slicoss: Clean up tabs vs spaces in slic.h
Date: Mon, 23 Jul 2012 10:01:50 +0300 [thread overview]
Message-ID: <20120723070150.GA4352@mwanda> (raw)
In-Reply-To: <alpine.LNX.2.00.1207222253370.31033@swampdragon.chaosbits.net>
On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote:
> Make it match CodingStyle a bit better, tab/space wise.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> drivers/staging/slicoss/slic.h | 751 ++++++++++++++++++++---------------------
> 1 file changed, 374 insertions(+), 377 deletions(-)
>
> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h
> index ebdcc6f..0deb670 100644
> --- a/drivers/staging/slicoss/slic.h
> +++ b/drivers/staging/slicoss/slic.h
> @@ -42,61 +42,62 @@
> #define __SLIC_DRIVER_H__
>
> /* firmware stuff */
> -#define OASIS_UCODE_VERS_STRING "1.2"
> -#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37"
> -#define OASIS_UCODE_HOSTIF_ID 3
> +#define OASIS_UCODE_VERS_STRING "1.2"
> +#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37"
> +#define OASIS_UCODE_HOSTIF_ID 3
No. The original was far better.
Looking through the rest of the patch, some of these changes are ok,
and some are nonsense.
regards,
dan carpenter
next prev parent reply other threads:[~2012-07-23 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 20:57 [PATCH 1/2] Staging: slicoss: Clean up tabs vs spaces in slic.h Jesper Juhl
2012-07-23 7:01 ` Dan Carpenter [this message]
2012-07-23 8:48 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723070150.GA4352@mwanda \
--to=dan.carpenter@oracle.com \
--cc=charrer@alacritech.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=liodot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.