From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/vtpm: fix version.h error during parallel build
Date: Mon, 23 Jul 2012 19:12:01 +0200 [thread overview]
Message-ID: <20120723171201.GA4555@aepfle.de> (raw)
In-Reply-To: <20493.33251.292891.101019@mariner.uk.xensource.com>
On Mon, Jul 23, Ian Jackson wrote:
> Olaf Hering writes ("[Xen-devel] [PATCH] tools/vtpm: fix version.h error during parallel build"):
> > tools/vtpm: fix version.h error during parallel build
> >
> > Generating the tpm_version.h is not make -j safe:
>
> Thanks for tracking this down. However, wouldn't it be possible to
> fix this entirely in our Makefile, somehow ? The patch to the
> upstream Makefile risks getting conflicts in the future with changes
> to the upstream code.
The build_sub rule in tools/vtpm/Makefile could be changed to
$(MAKE) -C $(VTPM_DIR) version && $(MAKE) -C $(VTPM_DIR) all-recursive; \
And the install rule in that Makefile perhaps to
$(MAKE) -C $(VTPM_DIR) install-recursive
I will see how that works, the failure happens rarely.
Olaf
next prev parent reply other threads:[~2012-07-23 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 15:08 [PATCH] tools/vtpm: fix version.h error during parallel build Olaf Hering
2012-07-23 16:54 ` Ian Jackson
2012-07-23 17:12 ` Olaf Hering [this message]
2012-07-23 17:14 ` Ian Jackson
2012-07-31 8:19 ` Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2012-07-12 7:51 Olaf Hering
2012-07-12 15:07 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120723171201.GA4555@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.