From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [next:akpm 244/309] lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_i
Date: Tue, 24 Jul 2012 03:49:50 +0000 [thread overview]
Message-ID: <20120724034950.GA6957@localhost> (raw)
In-Reply-To: <20120723082823.GA17005@arm.com>
On Mon, Jul 23, 2012 at 03:16:24PM -0700, Andrew Morton wrote:
> On Mon, 23 Jul 2012 09:28:23 +0100
> Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> > Hi Fengguang,
> >
> > On Mon, Jul 23, 2012 at 07:55:42AM +0100, Fengguang Wu wrote:
> > > There are new compile warnings show up in
> > >
> > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git akpm
> > > head: 37e2ad4953983527f7bdb6831bf478eedcc84082
> > > commit: ffacc905e2135e8408d43adbe0b8e21484b2c8e7 [244/309] atomic64_test: simplify the #ifdef for atomic64_dec_if_positive() test
> > > config: sparc-allmodconfig (attached as .config)
> > >
> > > All warnings:
> > >
> > > lib/atomic64_test.c: In function 'test_atomic64':
> > > lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol [-Wcpp]
> >
> > Is this a new warning in the sense that the string is different now? Or
> > you never got it before on sparc64. I don't have a sparc toolchain at
> > hand now but it looks to me like atomic64_test.c should have given the
> > warning before this patch as atomic64_dec_if_positive() does not seem to
> > be defined on sparc64.
> >
>
> Before:
> lib/atomic64_test.c:132:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture, and add it to the IF above
>
> After:
> lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_positive for your architecture and select the above Kconfig symbol
Exactly. That changed message text will be recognized by my dumb
script as "new" warning and I cannot do much about this..
Fengguang
next prev parent reply other threads:[~2012-07-24 3:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 8:28 [next:akpm 244/309] lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_i Catalin Marinas
2012-07-23 8:28 ` Catalin Marinas
2012-07-23 22:16 ` Andrew Morton
2012-07-24 3:49 ` Fengguang Wu [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-23 6:55 [next:akpm 244/309] lib/atomic64_test.c:131:2: warning: #warning Please implement atomic64_dec_if_po Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724034950.GA6957@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.