From: Borislav Petkov <bp@amd64.org>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Borislav Petkov" <borislav.petkov@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"André Przywara" <andre.przywara@amd.com>,
"Andreas Herrmann" <andreas.herrmann3@amd.com>
Subject: Re: [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features
Date: Tue, 24 Jul 2012 09:48:12 +0200 [thread overview]
Message-ID: <20120724074812.GA23541@aftab.osrc.amd.com> (raw)
In-Reply-To: <500E4960.8040307@parallels.com>
On Tue, Jul 24, 2012 at 11:06:08AM +0400, Vladimir Davydov wrote:
> If msr-tools are used for cpuid masking, we will either get
> inconsistency between /proc/cpuinfo:flags and the output of the cpuid
> instruction or have to "synchronize" the clearcpuid boot option and
> the userspace app using msr-tools, which seems to be inconvenient.
Right, so IMO what you want to do is not very kosher as a generic kernel
feature for reasons described earlier.
And yes, "synchronizing" /proc/cpuinfo's flags and CPUID output is a lot
less pain compared to having a generic abusable feature.
And also much better suited for your niche use case than opening this up
as a generic functionality to the wide public which will most definitely
find productive ways to abuse this.
Simply ask yourself this: is this something which the majority of
x86 linux users will benefit from or is it only something which is
nice-to-have solely for our single use case?
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
next prev parent reply other threads:[~2012-07-24 7:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 16:37 [PATCH 1/2] cpu: common: make clearcpuid option take bits list Vladimir Davydov
2012-07-20 16:37 ` [PATCH 2/2] cpu: intel, amd: mask cleared cpuid features Vladimir Davydov
2012-07-20 17:10 ` Andi Kleen
2012-07-20 17:18 ` H. Peter Anvin
2012-07-25 11:51 ` Vladimir Davydov
2012-07-20 17:20 ` H. Peter Anvin
2012-07-20 18:21 ` Vladimir Davydov
2012-07-20 20:19 ` H. Peter Anvin
2012-07-20 20:37 ` Vladimir Davydov
2012-07-21 10:37 ` Borislav Petkov
2012-07-24 7:06 ` Vladimir Davydov
2012-07-24 7:48 ` Borislav Petkov [this message]
2012-07-24 8:14 ` Andre Przywara
2012-07-24 8:29 ` Vladimir Davydov
2012-07-24 10:10 ` Borislav Petkov
2012-07-24 11:09 ` Vladimir Davydov
2012-07-24 12:34 ` Andre Przywara
2012-07-24 12:44 ` Alan Cox
2012-07-25 10:31 ` Vladimir Davydov
2012-07-25 10:58 ` Andre Przywara
2012-07-25 11:02 ` Vladimir Davydov
2012-07-25 11:17 ` Andre Przywara
2012-07-25 11:43 ` Vladimir Davydov
2012-07-25 11:31 ` Alan Cox
2012-07-25 11:46 ` Vladimir Davydov
2012-07-25 10:31 ` Vladimir Davydov
2012-07-25 10:43 ` Borislav Petkov
2012-07-25 11:39 ` Vladimir Davydov
2012-07-25 0:57 ` H. Peter Anvin
2012-07-25 6:58 ` Vladimir Davydov
2012-07-25 14:13 ` H. Peter Anvin
2012-07-25 11:49 ` Vladimir Davydov
2012-07-24 9:50 ` Borislav Petkov
2012-07-24 10:32 ` Alan Cox
2012-07-24 11:04 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120724074812.GA23541@aftab.osrc.amd.com \
--to=bp@amd64.org \
--cc=ak@linux.intel.com \
--cc=andre.przywara@amd.com \
--cc=andreas.herrmann3@amd.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vdavydov@parallels.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.