From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 00/25] make *struct of_device_id.data const Date: Tue, 24 Jul 2012 15:01:47 +0000 Message-ID: <201207241501.48302.arnd@arndb.de> References: <1343034810-3386-1-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1343034810-3386-1-git-send-email-u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Cc: Benjamin Herrenschmidt , Wim Van Sebroeck , Paul Mackerras , Kevin Hilman , Russell King , Samuel Ortiz , Vinod Koul , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Chris Ball , cbe-oss-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Marc Kleine-Budde , Ben Dooks , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Timur Tabi , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Cox , Linus Walleij , Greg Kroah-Hartman , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Oliver Hartkopp , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-mmc@vger.kernel.org T24gTW9uZGF5IDIzIEp1bHkgMjAxMiwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gdGhpcyBp cyB0aGUgMm5kIHZlcnNpb24gb2YgdGhpcyBzZXJpZXMgd2hvc2UgZ29hbCBpcyB0byBtYWtlIHN0 cnVjdAo+IG9mX2RldmljZV9pZC5kYXRhIGNvbnN0LiBDb25jZXB0dWFsbHkgYSBkcml2ZXIgbXVz dCBub3QgbW9kaWZ5IHRoZSBkYXRhCj4gY29udGFpbmVkIHRoZXJlIHNvIG1ha2luZyBpdCBjb25z dCBpcyB0aGUgcmlnaHQgdGhpbmcuCj4gCj4gdjEgb2YgdGhpcyBzZXJpZXMgd2FzIHNlbnQgd2l0 aCBNZXNzYWdlLWlkOgo+IDEzNDIxODI3MzQtMzIxLTEtZ2l0LXNlbmQtZW1haWwteS4gQ2hhbmdl cyBzaW5jZSB0aGVuIGFyZToKPiAgLSBwb3dlcnBjIGZpeGVzCj4gIC0gc2V2ZXJhbCBuZXcgY29u c3RzIHRoYXQgd2VyZSBmb3VuZCBieSBBcm5kIHRoYXQgYXJlIHBvc3NpYmxlIGFmdGVyCj4gICAg cGF0Y2ggMTkuCj4gICAgCj4gQXJuZCBzdWdnZXN0ZWQgdG8gdGFrZSB0aGlzIHNlcmllcyB2aWEg YXJtLXNvYyBsYXRlIGZvciAzLjYgaW4gb25lIGdvCj4gYmVjYXVzZSBwYXRjaCAxOSBkZXBlbmRz IG9uIHRoZSBmb3JtZXIgcGF0Y2hlcyBidXQgaXMgYSBwcmVjb25kaXRpb24gdG8KPiB0aGUgbGF0 dGVyIGFuZCBpdCBmaXhlcyBhIGZldyB3YXJuaW5ncy4gU28gZ2V0dGluZyBpdCBpbiB2aWEgdGhl Cj4gcmVzcGVjdGl2ZSBtYWludGFpbmVyIHRyZWVzIHdvdWxkIG5lZWQgYSBtdWNoIGJpZ2dlciBj b29yZGluYXRpb24KPiBlZmZvcnQuIFRoYXQgbWVhbnMgSSBwcmVmZXIgZ2V0dGluZyBBY2tzIG92 ZXIgeW91IHRha2luZyB0aGUgcGF0Y2guCj4gCj4gVmlub2QgS291bCBhbHJlYWR5IHRvb2sKPiAg ICAgICAgIGRtYWVuZ2luZTogYXRfaGRtYWM6IGFkZCBhIGZldyBjb25zdCBxdWFsaWZpZXJzCj4g dGhhdCBpcyBpbiBuZXh0LTIwMTIwNzIzIGFzIDdmZDYzY2NkYWQ3MiBub3cuIFZpbm9kLCBJIGRv bid0IGZvbGxvdyB5b3VyCj4gcHVsbCByZXF1ZXN0cywgYnV0IGFzc3VtaW5nIHlvdSBkaWRuJ3Qg bGV0IGl0IGFscmVhZHkgcHVsbCBmb3IgMy42IEkKPiBzdWdnZXN0IHlvdSBkcm9wIGl0IGZyb20g eW91ciBxdWV1ZSBhbmQgSSBqdXN0IHRha2UgeW91ciBBY2suCj4gCj4gVGhpcyBzZXJpZXMgd2Fz IGJ1aWxkIHRlc3RlZCBmb3IgYXJtIChhbGwgZGVmY29uZmlncykgYW5kIHBvd2VycGMgKGFsbAo+ IGRlZmNvbmZpZ3MgYW5kIGFuIGFsbHllc2NvbmZpZykgYW5kIGdyZXAgZGlkbid0IGZpbmQgbW9y ZSBpc3N1ZXMuIEFzCj4gYmVmb3JlIGl0IGludHJvZHVjZXMgYSB3YXJuaW5nIGluIGRyaXZlcnMv cmVndWxhdG9yL3R3bC1yZWd1bGF0b3IuYy4KPiBUaGlzIGRyaXZlciBkb2VzIG1vZGlmeSBpdHMg Lm9mX21hdGNoX3RhYmxlIHdoZW4gYSBkZXZpY2UgaXMgYm91bmQgd2hpY2gKPiBkb2Vzbid0IGZp dHMgdGhlIGNvbmNlcHQgb2YgaW5kZXBlbmRhbnQgZGV2aWNlcy4gQXJuZCBub3RpY2VkIGFub3Ro ZXIKPiBuZXcgd2FybmluZyBpbiBkcml2ZXJzL3Njc2kvcWxvZ2ljcHRpLmMgdGhhdCBpc24ndCB0 aGF0IGVhc3kgdG8gcmVzb2x2ZSwKPiBiZWNhdXNlIHRoZSBwb2ludGVyIHRvIChub3cpIGNvbnN0 IGRhdGEgaXMgcGFzc2VkIGFzIGZpcnN0IGFyZ3VtZW50IHRvCj4gc2NzaV9ob3N0X2FsbG9jLiBU byBmaXggdGhhdCBwcm9wZXJseSBzdHJ1Y3QgU2NzaV9Ib3N0Lmhvc3R0IG5lZWRzIHRvCj4gZ2V0 IGEgY29uc3QsIHRvby4gQWx0ZXJuYXRpdmVseSBJIGNvdWxkIGludHJvZHVjZSBhIGNhc3QgcmVt b3ZpbmcgdGhlCj4gY29uc3QsIGJ1dCBJIGRvbid0IGxpa2UgdGhhdC4KPiAKPiBUaGlzIHNlcmll cyBpcyBhbHNvIGF2YWlsYWJsZSBhdDoKPiAKPiAgICAgICAgIGdpdDovL2dpdC5wZW5ndXRyb25p eC5kZS9naXQvdWtsL2xpbnV4LmdpdCBvZmRldmljZWlkZGF0YQo+IAo+IGFuZCBJIHdpbGwgbW9k aWZ5IGl0IHRoZXJlIGZvciB0aGUgQWNrcyBJJ20gZ2V0dGluZy4KClB1bGxlZCB0aGUgZW50aXJl IHNlcmllcyBpbnRvIGFybS1zb2MvbGF0ZS93YXJuaW5ncy4gVGhhbmtzIGV2ZXJ5b25lCndobyBw cm92aWRlZCBBY2tzLiBJJ2xsIHdhaXQgZm9yIGEgZmV3IG1vcmUgZGF5cyB0byBsZXQgdGhpcyBz aXQKaW4gbGludXgtbmV4dCBhbmQgaWYgbm9ib2R5IGNvbXBsYWlucywgT2xvZiBvciBJIHdpbGwg Zm9yd2FyZCBpdAp0byBMaW51cy4KCglBcm5kCgotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KTGl2ZSBT ZWN1cml0eSBWaXJ0dWFsIENvbmZlcmVuY2UKRXhjbHVzaXZlIGxpdmUgZXZlbnQgd2lsbCBjb3Zl ciBhbGwgdGhlIHdheXMgdG9kYXkncyBzZWN1cml0eSBhbmQgCnRocmVhdCBsYW5kc2NhcGUgaGFz IGNoYW5nZWQgYW5kIGhvdyBJVCBtYW5hZ2VycyBjYW4gcmVzcG9uZC4gRGlzY3Vzc2lvbnMgCndp bGwgaW5jbHVkZSBlbmRwb2ludCBzZWN1cml0eSwgbW9iaWxlIHNlY3VyaXR5IGFuZCB0aGUgbGF0 ZXN0IGluIG1hbHdhcmUgCnRocmVhdHMuIGh0dHA6Ly93d3cuYWNjZWxhY29tbS5jb20vamF3L3Nm cm5sMDQyNDIwMTIvMTE0LzUwMTIyMjYzLwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpzcGktZGV2ZWwtZ2VuZXJhbCBtYWlsaW5nIGxpc3QKc3BpLWRldmVs LWdlbmVyYWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2Uu bmV0L2xpc3RzL2xpc3RpbmZvL3NwaS1kZXZlbC1nZW5lcmFsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 24 Jul 2012 15:01:47 +0000 Subject: [PATCH v2 00/25] make *struct of_device_id.data const In-Reply-To: <1343034810-3386-1-git-send-email-u.kleine-koenig@pengutronix.de> References: <1343034810-3386-1-git-send-email-u.kleine-koenig@pengutronix.de> Message-ID: <201207241501.48302.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 23 July 2012, Uwe Kleine-K?nig wrote: > this is the 2nd version of this series whose goal is to make struct > of_device_id.data const. Conceptually a driver must not modify the data > contained there so making it const is the right thing. > > v1 of this series was sent with Message-id: > 1342182734-321-1-git-send-email-y. Changes since then are: > - powerpc fixes > - several new consts that were found by Arnd that are possible after > patch 19. > > Arnd suggested to take this series via arm-soc late for 3.6 in one go > because patch 19 depends on the former patches but is a precondition to > the latter and it fixes a few warnings. So getting it in via the > respective maintainer trees would need a much bigger coordination > effort. That means I prefer getting Acks over you taking the patch. > > Vinod Koul already took > dmaengine: at_hdmac: add a few const qualifiers > that is in next-20120723 as 7fd63ccdad72 now. Vinod, I don't follow your > pull requests, but assuming you didn't let it already pull for 3.6 I > suggest you drop it from your queue and I just take your Ack. > > This series was build tested for arm (all defconfigs) and powerpc (all > defconfigs and an allyesconfig) and grep didn't find more issues. As > before it introduces a warning in drivers/regulator/twl-regulator.c. > This driver does modify its .of_match_table when a device is bound which > doesn't fits the concept of independant devices. Arnd noticed another > new warning in drivers/scsi/qlogicpti.c that isn't that easy to resolve, > because the pointer to (now) const data is passed as first argument to > scsi_host_alloc. To fix that properly struct Scsi_Host.hostt needs to > get a const, too. Alternatively I could introduce a cast removing the > const, but I don't like that. > > This series is also available at: > > git://git.pengutronix.de/git/ukl/linux.git ofdeviceiddata > > and I will modify it there for the Acks I'm getting. Pulled the entire series into arm-soc/late/warnings. Thanks everyone who provided Acks. I'll wait for a few more days to let this sit in linux-next and if nobody complains, Olof or I will forward it to Linus. Arnd