From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 09/10 RESEND] spi: Add SSP/SPI device tree documentation Date: Tue, 24 Jul 2012 21:43:48 +0200 Message-ID: <201207242143.49038.marex@denx.de> References: <1343076052-27312-1-git-send-email-marex@denx.de> <1343076052-27312-10-git-send-email-marex@denx.de> <500EE64B.8080103@mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Fabio Estevam , Chris Ball , Mark Brown , Attila Kinali , spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Shawn Guo , Dong Aisheng , Linux ARM kernel To: Sergei Shtylyov Return-path: In-Reply-To: <500EE64B.8080103-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org Dear Sergei Shtylyov, > Hello. > > On 07/24/2012 12:40 AM, Marek Vasut wrote: > > Signed-off-by: Marek Vasut > > Cc: Attila Kinali > > Cc: Chris Ball > > CC: Dong Aisheng > > Cc: Fabio Estevam > > Cc: Grant Likely > > Cc: Linux ARM kernel > > Cc: Mark Brown > > CC: Shawn Guo > > --- > > > > Documentation/devicetree/bindings/spi/mxs-spi.txt | 18 > > ++++++++++++++++++ 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt > > b/Documentation/devicetree/bindings/spi/mxs-spi.txt new file mode 100644 > > index 0000000..f1263a9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.txt > > @@ -0,0 +1,18 @@ > > +* Freescale MX233/MX28 SSP/SPI > > + > > +Required properties: > > +- compatible: Should be "fsl,-spi", where soc is "imx23" or "imx28" > > +- reg: Offset and length of the register set for the device > > +- interrupts: Should contain SSP interrupts (error irq first, dma irq > > second) +- fsl,ssp-dma-channel: APBX DMA channel for the SSP > > + > > +Example: > > + > > +ssp0: ssp@80010000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "fsl,imx28-spi"; > > + reg = <0x80010000 2000>; > > Not 0x2000? This is actually not the first place I was curious about in the imx28 DTS ... yes, the size is 0x2000, but "2000" as is is used in multiple places across imx28. Shawn? > WBR, Sergei Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: marex@denx.de (Marek Vasut) Date: Tue, 24 Jul 2012 21:43:48 +0200 Subject: [PATCH 09/10 RESEND] spi: Add SSP/SPI device tree documentation In-Reply-To: <500EE64B.8080103@mvista.com> References: <1343076052-27312-1-git-send-email-marex@denx.de> <1343076052-27312-10-git-send-email-marex@denx.de> <500EE64B.8080103@mvista.com> Message-ID: <201207242143.49038.marex@denx.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Sergei Shtylyov, > Hello. > > On 07/24/2012 12:40 AM, Marek Vasut wrote: > > Signed-off-by: Marek Vasut > > Cc: Attila Kinali > > Cc: Chris Ball > > CC: Dong Aisheng > > Cc: Fabio Estevam > > Cc: Grant Likely > > Cc: Linux ARM kernel > > Cc: Mark Brown > > CC: Shawn Guo > > --- > > > > Documentation/devicetree/bindings/spi/mxs-spi.txt | 18 > > ++++++++++++++++++ 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt > > b/Documentation/devicetree/bindings/spi/mxs-spi.txt new file mode 100644 > > index 0000000..f1263a9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.txt > > @@ -0,0 +1,18 @@ > > +* Freescale MX233/MX28 SSP/SPI > > + > > +Required properties: > > +- compatible: Should be "fsl,-spi", where soc is "imx23" or "imx28" > > +- reg: Offset and length of the register set for the device > > +- interrupts: Should contain SSP interrupts (error irq first, dma irq > > second) +- fsl,ssp-dma-channel: APBX DMA channel for the SSP > > + > > +Example: > > + > > +ssp0: ssp at 80010000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "fsl,imx28-spi"; > > + reg = <0x80010000 2000>; > > Not 0x2000? This is actually not the first place I was curious about in the imx28 DTS ... yes, the size is 0x2000, but "2000" as is is used in multiple places across imx28. Shawn? > WBR, Sergei Best regards, Marek Vasut