From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5H9-00058G-Rb
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:21:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5H8-0001mL-HK
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:21:31 -0400
Received: from paradis.irqsave.net ([109.190.18.76]:50780)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benoit.canet@irqsave.net>) id 1Su5H8-0001mF-9W
	for qemu-devel@nongnu.org; Wed, 25 Jul 2012 13:21:30 -0400
Date: Wed, 25 Jul 2012 19:21:27 +0200
From: =?iso-8859-1?Q?Beno=EEt?= Canet <benoit.canet@irqsave.net>
Message-ID: <20120725172127.GG12455@irqsave.net>
References: <1343219765-12297-1-git-send-email-benoit@irqsave.net>
	<1343219765-12297-3-git-send-email-benoit@irqsave.net>
	<5010212F.7030304@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <5010212F.7030304@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V3 2/3] block: Use
 bdrv_get_backing_file_ancestors_count()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, benoit.canet@gmail.com, stefanha@linux.vnet.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com

Le Wednesday 25 Jul 2012 =E0 10:39:11 (-0600), Eric Blake a =E9crit :
> On 07/25/2012 06:36 AM, benoit.canet@gmail.com wrote:
>=20
> > +++ b/qapi-schema.json
> > @@ -398,6 +398,8 @@
> >  #
> >  # @backing_file: #optional the name of the backing file (for copy-on=
-write)
> >  #
> > +# @backing_file_ancestors_count: #the count of ancestors backing fil=
es (since: 1.2)
> > +#
> >  # @encrypted: true if the backing device is encrypted
> >  #
> >  # @bps: total throughput limit in bytes per second is specified
> > @@ -418,9 +420,10 @@
> >  ##
> >  { 'type': 'BlockDeviceInfo',
> >    'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str',
> > -            '*backing_file': 'str', 'encrypted': 'bool',
> > -            'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int',
> > -            'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} }
> > +            '*backing_file': 'str', 'backing_file_ancestors_count': =
'int',
>=20
> I hit send too soon.  QMP prefers '-' over '_', so the new parameter
> should be 'backing-file-ancestors-count' (or with my proposal,
> 'backing-file-depth').  Yes, this particular struct has some _ for
> historical reasons, but that doesn't mean that new elements must share
> the misery.

I'll change it too.

Beno=EEt
>=20
> --=20
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>=20