From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael G Schwern <schwern@pobox.com>
Cc: git@vger.kernel.org, gitster@pobox.com, robbat2@gentoo.org,
bwalton@artsci.utoronto.ca, normalperson@yhbt.net
Subject: Re: [PATCH 3/3] The Makefile.PL will now find .pm files itself.
Date: Wed, 25 Jul 2012 16:56:17 -0500 [thread overview]
Message-ID: <20120725215617.GI4732@burratino> (raw)
In-Reply-To: <501069E9.2000009@pobox.com>
Michael G Schwern wrote:
> On 2012.7.25 2:11 PM, Jonathan Nieder wrote:
>> Who are these comments in perl/Makefile.PL addressed to?
>
> Somebody adding, renaming or deleting a .pm file.
>
>> Why would such a person be looking at perl/Makefile.PL?
>
> Because sometimes they do wacky things
Not convincing at all. ;-)
But my made-up justification about people making other changes to
perl/Makefile.PL convinced me, so keeping the comments seems fine to
me now.
[...]
> For my purposes, I just preserved the comment.
That's what I feared and how cruft collects. Sorry for the lack of
clarity.
Thanks,
Jonathan
next prev parent reply other threads:[~2012-07-25 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 3:21 Teach Makefile.PL to find .pm files on its own Michael G. Schwern
2012-07-25 3:21 ` [PATCH 1/3] Quiet warning if Makefile.PL is run with -w and no --localedir Michael G. Schwern
2012-07-25 3:21 ` [PATCH 2/3] Don't lose Error.pm if $@ gets clobbered Michael G. Schwern
2012-07-25 3:21 ` [PATCH 3/3] The Makefile.PL will now find .pm files itself Michael G. Schwern
2012-07-25 21:11 ` Jonathan Nieder
2012-07-25 21:31 ` Jonathan Nieder
2012-07-25 21:49 ` Michael G Schwern
2012-07-25 21:56 ` Jonathan Nieder [this message]
2012-07-25 16:56 ` Teach Makefile.PL to find .pm files on its own Junio C Hamano
2012-07-25 20:26 ` Michael G Schwern
2012-07-25 20:32 ` Junio C Hamano
2012-07-25 21:12 ` Michael G Schwern
2012-07-25 22:19 ` Junio C Hamano
2012-07-25 22:56 ` Michael G Schwern
2012-07-25 23:29 ` Junio C Hamano
2012-07-25 23:37 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725215617.GI4732@burratino \
--to=jrnieder@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=robbat2@gentoo.org \
--cc=schwern@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.