From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anton Arapov <anton@redhat.com>, Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] uprobes: fix register_for_each_vma()->vma_address() check
Date: Thu, 26 Jul 2012 10:29:48 +0530 [thread overview]
Message-ID: <20120726045948.GC3810@linux.vnet.ibm.com> (raw)
In-Reply-To: <20120712171020.GA25500@redhat.com>
* Oleg Nesterov <oleg@redhat.com> [2012-07-12 19:10:20]:
> 1. register_for_each_vma() checks that vma_address() == vaddr but
> this is not enough. We should also ensure that vaddr >= vm_start,
> find_vma() guarantees "vaddr < vm_end" only.
>
> 2. After the prevous changes, register_for_each_vma() is the only
> reason why vma_address() has to return loff_t, all other users
> know that we have the valid mapping at this offset and thus the
> overflow is not possible.
>
> Change the code to use vaddr_to_offset() instead, imho this looks
> more clean/understandable and now we can change vma_address().
>
> 3. While at it, remove the unnecessary type-cast.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
next prev parent reply other threads:[~2012-07-26 5:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 17:09 [PATCH 0/4] uprobes: vma_address() fixlets Oleg Nesterov
2012-07-12 17:10 ` [PATCH 1/4] uprobes: introduce vaddr_to_offset(vma, vaddr) Oleg Nesterov
2012-07-26 4:58 ` Srikar Dronamraju
2012-07-12 17:10 ` [PATCH 2/4] uprobes: fix register_for_each_vma()->vma_address() check Oleg Nesterov
2012-07-26 4:59 ` Srikar Dronamraju [this message]
2012-07-12 17:10 ` [PATCH 3/4] uprobes: rename vma_address() and make it return "unsigned long" Oleg Nesterov
2012-07-26 5:00 ` Srikar Dronamraju
2012-07-26 10:28 ` Oleg Nesterov
2012-07-27 6:22 ` Srikar Dronamraju
2012-07-12 17:10 ` [PATCH 4/4] uprobes: __replace_page() needs munlock_vma_page() Oleg Nesterov
2012-07-26 5:18 ` Srikar Dronamraju
2012-07-26 10:16 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726045948.GC3810@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ananth@in.ibm.com \
--cc=anton@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.