All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/1] kirkwood: set tx_csum_limit
Date: Thu, 26 Jul 2012 11:45:51 +0200	[thread overview]
Message-ID: <20120726094551.GA14943@lunn.ch> (raw)
In-Reply-To: <87r4ry98i0.fsf@lebrac.rtp-net.org>

> >>  	orion_ge00_init(eth_data, DOVE_GE00_PHYS_BASE,
> >> -			IRQ_DOVE_GE00_SUM, IRQ_DOVE_GE00_ERR);
> >> +			IRQ_DOVE_GE00_SUM, IRQ_DOVE_GE00_ERR, 0);
> >>  }
> >
> > You might want to add a constant for TX_CSUM_NO_LIMIT or something like that, 
> > rather than a plain 0 which might be a little misleading.
> >
> 
> It's not to set an unlimited value but to tell the driver it has to
> use its default value. This limit is only valid for kirkwood but given
> that orion_ge*_init functions are used on all platforms, I have to set 

So how about TX_CSUM_DEFAULT_LIMIT?

It would also be nice if you could change the change log text to
something like:

ARM: Orion: Set eth packet size csum offload limit

The mv643xx ethernet controller limits the packet size for the TX
checksum offloading. This patch sets this limits for Kirkwood and
Dove which have smaller limits that the default.

I would like to consistently use the prefixes:

ARM: Orion: 
ARM: Kirkwood:
ARM: Dove:
ARM: Orion5x:
...

   Thanks
	Andrew

  parent reply	other threads:[~2012-07-26  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26  7:12 [patch 1/1] kirkwood: set tx_csum_limit Arnaud Patard (Rtp)
2012-07-26  9:15 ` Florian Fainelli
2012-07-26  9:28   ` Arnaud Patard (Rtp)
2012-07-26  9:44     ` Florian Fainelli
2012-07-26  9:45     ` Andrew Lunn [this message]
2012-07-26 10:15       ` Arnaud Patard (Rtp)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120726094551.GA14943@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.