From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set
Date: Thu, 26 Jul 2012 14:22:48 +0200 [thread overview]
Message-ID: <20120726122248.GA252@x4> (raw)
Every time I start qemu-kvm on my system the following line is added to
the syslog:
vcpu0 unhandled rdmsr: 0xc0010001
AFAICS all calls to vcpu_unimpl only contain debugging info with little
or no value for the end user.
Wouldn't something like the following patch make sense?
Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index b70b48b..6bd816f 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -321,7 +321,7 @@ struct kvm {
#define kvm_debug(fmt, ...) \
pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)
#define kvm_pr_unimpl(fmt, ...) \
- pr_err_ratelimited("kvm [%i]: " fmt, \
+ pr_debug_ratelimited("kvm [%i]: " fmt, \
task_tgid_nr(current), ## __VA_ARGS__)
/* The guest did something we don't support. */
--
Markus
next reply other threads:[~2012-07-26 12:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 12:22 Markus Trippelsdorf [this message]
2012-08-01 3:19 ` [RFC PATCH] KVM: Only print vcpu_unimpl when DEBUG is set Marcelo Tosatti
2012-08-01 8:41 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726122248.GA252@x4 \
--to=markus@trippelsdorf.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.