From: willy@linux.intel.com (Matthew Wilcox)
Subject: [PATCH] NVMe: use namespace id for nvme_get_features
Date: Thu, 26 Jul 2012 12:46:25 -0400 [thread overview]
Message-ID: <20120726164625.GG22985@linux.intel.com> (raw)
In-Reply-To: <1343253998-32681-1-git-send-email-keith.busch@intel.com>
On Wed, Jul 25, 2012@04:06:38PM -0600, Keith Busch wrote:
> The specification does not provide a use for command dword11 in the NVMe Get
> Features command, but does use the NSID for some features.
... proof that one shouldn't write both sides of a protocol.
Thanks, applied.
> Signed-off-by: Keith Busch <keith.busch at intel.com>
> ---
> drivers/block/nvme.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/nvme.c b/drivers/block/nvme.c
> index 38b9c73..c4ba0f7 100644
> --- a/drivers/block/nvme.c
> +++ b/drivers/block/nvme.c
> @@ -840,15 +840,15 @@ static int nvme_identify(struct nvme_dev *dev, unsigned nsid, unsigned cns,
> }
>
> static int nvme_get_features(struct nvme_dev *dev, unsigned fid,
> - unsigned dword11, dma_addr_t dma_addr)
> + unsigned nsid, dma_addr_t dma_addr)
> {
> struct nvme_command c;
>
> memset(&c, 0, sizeof(c));
> c.features.opcode = nvme_admin_get_features;
> + c.features.nsid = cpu_to_le32(nsid);
> c.features.prp1 = cpu_to_le64(dma_addr);
> c.features.fid = cpu_to_le32(fid);
> - c.features.dword11 = cpu_to_le32(dword11);
>
> return nvme_submit_admin_cmd(dev, &c, NULL);
> }
> --
> 1.7.0.4
>
>
> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme at lists.infradead.org
> http://merlin.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2012-07-26 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 22:06 [PATCH] NVMe: use namespace id for nvme_get_features Keith Busch
2012-07-26 16:46 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726164625.GG22985@linux.intel.com \
--to=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.