From: Matthew Garrett <mjg@redhat.com>
To: Khalid Aziz <khalid.aziz@hp.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
mikew@google.com, tony.luck@intel.com, keescook@chromium.org,
gong.chen@linux.intel.com, gregkh@suse.de,
paul.gortmaker@windriver.com, maxin.john@gmail.com,
rdunlap@xenotime.net, matt.fleming@intel.com, olof@lixom.net,
dhowells@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Shorten constant names for EFI variable attributes
Date: Thu, 26 Jul 2012 18:33:33 +0100 [thread overview]
Message-ID: <20120726173332.GA19851@srcf.ucam.org> (raw)
In-Reply-To: <50117E40.8090904@hp.com>
On Thu, Jul 26, 2012 at 11:28:32AM -0600, Khalid Aziz wrote:
> I also do not believe that kernel must use the constant names
> mentioned in the specification especially when the name reaches 50
> characters. We can not get away from having to create aliases. Do
> you think having aliases in efi.h can cause mixed use of long names
> and short names in future code in the kernel? Can we address this by
> suggesting to future code authors that they should use the short
> names in their code? Should we consider inclusion of this patch in
> the kernel?
I'd be surprised if it were a problem - we should catch any of those
cases in code review, or gate the aliases under #ifndef __KERNEL__
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-07-26 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 22:08 [PATCH] Shorten constant names for EFI variable attributes Khalid Aziz
2012-07-20 22:10 ` H. Peter Anvin
2012-07-20 22:30 ` Khalid Aziz
2012-07-20 22:34 ` H. Peter Anvin
2012-07-20 22:46 ` Khalid Aziz
2012-07-23 13:26 ` Matthew Garrett
2012-07-26 17:28 ` Khalid Aziz
2012-07-26 17:33 ` Matthew Garrett [this message]
2012-09-25 15:41 ` [PATCH -next v2] " Khalid Aziz
2012-09-25 21:55 ` Stephen Rothwell
2012-09-25 23:06 ` Khalid Aziz
2012-09-25 23:12 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726173332.GA19851@srcf.ucam.org \
--to=mjg@redhat.com \
--cc=dhowells@redhat.com \
--cc=gong.chen@linux.intel.com \
--cc=gregkh@suse.de \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=khalid.aziz@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=maxin.john@gmail.com \
--cc=mikew@google.com \
--cc=olof@lixom.net \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.