From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "Philippe Rétornaz" <philippe.retornaz@epfl.ch>,
alsa-devel@alsa-project.org, "Fabio Estevam" <festevam@gmail.com>,
"Sascha Hauer" <kernel@pengutronix.de>
Subject: Re: Crash when probing imx_mc13783
Date: Thu, 26 Jul 2012 21:19:44 +0100 [thread overview]
Message-ID: <20120726201944.GA4560@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <50116D38.6050001@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 614 bytes --]
On Thu, Jul 26, 2012 at 05:15:52PM +0100, Lee Jones wrote:
> The patch is apparently not correct (although, I do see a place for
> it). The problem is that unless your code populates
No, really. There's no place for it. Think about what it does - it
takes the code that sets up the shared I/O accessors and changes it so
that if the code is explicitly asked to set up regmap accessors it might
just ignore that and not tell anyone. Clearly this is not a good idea,
this code has a simple job to do and you're making it more fragile and
obscure.
That change is clearly working at the wrong abstraction layer.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2012-07-26 20:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 19:56 Crash when probing imx_mc13783 Fabio Estevam
2012-07-26 7:29 ` Philippe Rétornaz
2012-07-26 15:40 ` Fabio Estevam
2012-07-26 16:15 ` Lee Jones
2012-07-26 17:16 ` Fabio Estevam
2012-07-26 20:20 ` Mark Brown
2012-07-26 20:19 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726201944.GA4560@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=philippe.retornaz@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.