From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sconeserver: new package
Date: Fri, 27 Jul 2012 08:34:53 +0200 [thread overview]
Message-ID: <20120727083453.7be325d8@skate> (raw)
In-Reply-To: <CAHXCMMLwWEA-eyQ9GZpa0L2o2QgxAE38W64LgDBfTRHD5iP45g@mail.gmail.com>
Le Fri, 27 Jul 2012 01:14:43 +0200,
Samuel Martin <s.martin49@gmail.com> a ?crit :
> Since the ssl option (like most of of the following ones) has effect
> on both SCONESERVER_DEPENDENCIES and SCONESERVER_CONF_OPT,
> I would prefer to see them nested in the same if[n]eq statement:
>
> ifneq ($(BR2_PACKAGE_SCONESERVER_SSL),)
> SCONESERVER_CONF_OPT += --with-ssl
> SCONESERVER_DEPENDENCIES += openssl
> else
> SCONESERVER_CONF_OPT += --without-ssl
> endif
>
> IMO, this makes things easier to maintain.
I agree. It's a bit longer from a number of lines perspective, but it's
much more logical, IMO.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-07-27 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 13:49 [Buildroot] [PATCH] sconeserver: new package spdawson at gmail.com
2012-07-26 16:57 ` Arnout Vandecappelle
2012-07-26 23:14 ` Samuel Martin
2012-07-27 6:34 ` Thomas Petazzoni [this message]
2012-07-27 6:45 ` Thomas Petazzoni
2012-07-27 8:12 ` Simon Dawson
2012-07-27 8:27 ` Arnout Vandecappelle
2012-07-27 8:38 ` Simon Dawson
2012-07-27 8:39 ` Thomas Petazzoni
2012-07-27 8:43 ` Simon Dawson
2012-07-27 8:42 ` Simon Dawson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120727083453.7be325d8@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.