From mboxrd@z Thu Jan 1 00:00:00 1970 From: majianpeng Subject: [RFC PATCH] fs/direct-io.c: Set bi_rw when alloc bio. Date: Fri, 27 Jul 2012 16:02:10 +0800 Message-ID: <201207271602081096921@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 Return-path: Sender: linux-fsdevel-owner@vger.kernel.org To: viro , Neil Brown Cc: linux-fsdevel , linux-kernel , linux-raid List-Id: linux-raid.ids V2hlbiBleGVjIGJpb19hbGxvYywgdGhlIGJpX3J3IGlzIHplcm8uQnV0IGFmdGVyIGNhbGxpbmcg YmlvX2FkZF9wYWdlLA0KaXQgd2lsbCB1c2UgYmlfcncuDQpGb3ggZXhhbXBsZSwgaW4gZnVuY3Rp aW9uIF9fYmlvX2FkZF9wYWdlLGl0IHdpbGwgY2FsbCBtZXJnZV9idmVjX2ZuKCkuDQpUaGUgbWVy Z2VfYnZlY19mbiBvZiByYWlkNDU2IHdpbGwgdXNlIHRoZSBiaV9ydyB0byBqdWRnZSB0aGUgbWVy Z2UuDQo+PiBpZiAoKGJ2bS0+YmlfcncgJiAxKSA9PSBXUklURSkNCj4+CQlyZXR1cm4gYmlvdmVj LT5idl9sZW47IC8qIGFsd2F5cyBhbGxvdyB3cml0ZXMgdG8gYmUgbWVyZ2VhYmxlICovDQoNClNp Z25lZC1vZmYtYnk6IEppYW5wZW5nIE1hIDxtYWppYW5wZW5nQGdtYWlsLmNvbT4NCg0KVGhlcmUg YXJlIG1hbnkgcGxhY2UgbGlrZSB0aGlzIGluIGtlcm5lbC5JZiB5b3UgdGhpbmsgdGhpcyBwYXRj aCBvaywgaSB3aWxsIGNvcnJlY3QgdGhvc2UuDQotLS0NCiBmcy9kaXJlY3QtaW8uYyB8ICAgIDEg Kw0KIDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQ0KDQpk aWZmIC0tZ2l0IGEvZnMvZGlyZWN0LWlvLmMgYi9mcy9kaXJlY3QtaW8uYw0KaW5kZXggMWZhZjRj Yi4uNzdmMGJiZiAxMDA2NDQNCi0tLSBhL2ZzL2RpcmVjdC1pby5jDQorKysgYi9mcy9kaXJlY3Qt aW8uYw0KQEAgLTM0OSw2ICszNDksNyBAQCBkaW9fYmlvX2FsbG9jKHN0cnVjdCBkaW8gKmRpbywg c3RydWN0IGRpb19zdWJtaXQgKnNkaW8sDQogDQogCWJpby0+YmlfYmRldiA9IGJkZXY7DQogCWJp by0+Ymlfc2VjdG9yID0gZmlyc3Rfc2VjdG9yOw0KKwliaW8tPmJpX3J3ID0gZGlvLT5ydzsNCiAJ aWYgKGRpby0+aXNfYXN5bmMpDQogCQliaW8tPmJpX2VuZF9pbyA9IGRpb19iaW9fZW5kX2FpbzsN CiAJZWxzZQ0KLS0gDQoxLjcuNS40DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752192Ab2G0IBC (ORCPT ); Fri, 27 Jul 2012 04:01:02 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:49489 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751858Ab2G0IA7 (ORCPT ); Fri, 27 Jul 2012 04:00:59 -0400 Date: Fri, 27 Jul 2012 16:02:10 +0800 From: majianpeng To: viro , "Neil Brown" Cc: linux-fsdevel , linux-kernel , linux-raid Subject: [RFC PATCH] fs/direct-io.c: Set bi_rw when alloc bio. X-Priority: 3 X-Has-Attach: no X-Mailer: Foxmail 7.0.1.91[en] Mime-Version: 1.0 Message-ID: <201207271602081096921@gmail.com> Content-Type: text/plain; charset="gb2312" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id q6R81Y4V025754 When exec bio_alloc, the bi_rw is zero.But after calling bio_add_page, it will use bi_rw. Fox example, in functiion __bio_add_page,it will call merge_bvec_fn(). The merge_bvec_fn of raid456 will use the bi_rw to judge the merge. >> if ((bvm->bi_rw & 1) == WRITE) >> return biovec->bv_len; /* always allow writes to be mergeable */ Signed-off-by: Jianpeng Ma There are many place like this in kernel.If you think this patch ok, i will correct those. --- fs/direct-io.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/direct-io.c b/fs/direct-io.c index 1faf4cb..77f0bbf 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -349,6 +349,7 @@ dio_bio_alloc(struct dio *dio, struct dio_submit *sdio, bio->bi_bdev = bdev; bio->bi_sector = first_sector; + bio->bi_rw = dio->rw; if (dio->is_async) bio->bi_end_io = dio_bio_end_aio; else -- 1.7.5.4 {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I