From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build Date: Fri, 27 Jul 2012 13:29:27 -0700 Message-ID: <20120727202926.GC8262@dtor-ws.eng.vmware.com> References: <20120727103455.GA4639@merkur.ravnborg.org> <1693394101.5749000.1343409643934.JavaMail.root@vmware.com> <20120727181639.GA23564@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120727181639.GA23564@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Greg KH Cc: pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, vm-crosstalk@vmware.com, Andrew Stiegmann , Sam Ravnborg List-Id: virtualization@lists.linuxfoundation.org On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > The kernel style is to use lower_case for everything. > > > So this would become: > > > > > > vmci_device_get() > > > > > > This is obviously a very general comment and applies everywhere. > > > > I wish I could lower case these symbols but VMCI has already existed > > outside the mainline Linux tree for some time now and changing these > > exported symbols would mean that other drivers that depend on VMCI > > (vSock, vmhgfs) would need to change as well. One thought that did > > come to mind was exporting both VMCI_Device_Get and vmci_device_get > > but that would likely just confuse people. So in short I have made > > function names lower case where possible, but exported symbols could > > not be changed. > > Not true at all. You want those drivers to be merged as well, right? > So they will need to have their functions changed, and their code as > well. > > Just wait until we get to the "change your functionality around" > requests, those will require those drivers to change. Right now we are > at the "silly and obvious things you did wrong" stage of the review > process :) > > So please fix these, and also, post these drivers as well, so we can see > how they interact with the core code. > > Actually, if you are going to need lots of refactoring for these > drivers, and the core, I would recommend putting this all in the staging > tree, to allow that to happen over time. That would ensure that your > users keep having working systems, and let you modify the interfaces > better and easier, than having to keep it all out-of-tree. > > What do you think? Actually I think that we'd prefer to keep this in a patch-based form, at least for now, because majority of our users get these drivers with VMware Tools and will continue doing so until ditsributions start enabling VMCI in their kernels. Which they probably won't until VMCI moves form staging. We'd also have to constantly adjust drivers that we are not working on getting upstream at this time to work with the rapidly changing version of VMCI in staging, which will just add work for us. So we'd like to get more feedback and have a chance to address issues and then decide whether staying in staging makes sense or not. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322Ab2G0U32 (ORCPT ); Fri, 27 Jul 2012 16:29:28 -0400 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:37327 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820Ab2G0U31 (ORCPT ); Fri, 27 Jul 2012 16:29:27 -0400 Date: Fri, 27 Jul 2012 13:29:27 -0700 From: Dmitry Torokhov To: Greg KH Cc: Andrew Stiegmann , pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, vm-crosstalk@vmware.com, Sam Ravnborg Subject: Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build Message-ID: <20120727202926.GC8262@dtor-ws.eng.vmware.com> References: <20120727103455.GA4639@merkur.ravnborg.org> <1693394101.5749000.1343409643934.JavaMail.root@vmware.com> <20120727181639.GA23564@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120727181639.GA23564@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > The kernel style is to use lower_case for everything. > > > So this would become: > > > > > > vmci_device_get() > > > > > > This is obviously a very general comment and applies everywhere. > > > > I wish I could lower case these symbols but VMCI has already existed > > outside the mainline Linux tree for some time now and changing these > > exported symbols would mean that other drivers that depend on VMCI > > (vSock, vmhgfs) would need to change as well. One thought that did > > come to mind was exporting both VMCI_Device_Get and vmci_device_get > > but that would likely just confuse people. So in short I have made > > function names lower case where possible, but exported symbols could > > not be changed. > > Not true at all. You want those drivers to be merged as well, right? > So they will need to have their functions changed, and their code as > well. > > Just wait until we get to the "change your functionality around" > requests, those will require those drivers to change. Right now we are > at the "silly and obvious things you did wrong" stage of the review > process :) > > So please fix these, and also, post these drivers as well, so we can see > how they interact with the core code. > > Actually, if you are going to need lots of refactoring for these > drivers, and the core, I would recommend putting this all in the staging > tree, to allow that to happen over time. That would ensure that your > users keep having working systems, and let you modify the interfaces > better and easier, than having to keep it all out-of-tree. > > What do you think? Actually I think that we'd prefer to keep this in a patch-based form, at least for now, because majority of our users get these drivers with VMware Tools and will continue doing so until ditsributions start enabling VMCI in their kernels. Which they probably won't until VMCI moves form staging. We'd also have to constantly adjust drivers that we are not working on getting upstream at this time to work with the rapidly changing version of VMCI in staging, which will just add work for us. So we'd like to get more feedback and have a chance to address issues and then decide whether staying in staging makes sense or not. Thanks. -- Dmitry