From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sat, 28 Jul 2012 19:46:29 +0200 Subject: [U-Boot] [RFC] [PATCH 2/2] crazy: Sort u_boot_cmd at runtime In-Reply-To: <1343483279-11572-2-git-send-email-marex@denx.de> References: <1343483279-11572-1-git-send-email-marex@denx.de> <1343483279-11572-2-git-send-email-marex@denx.de> Message-ID: <20120728174629.725CD200346@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <1343483279-11572-2-git-send-email-marex@denx.de> you wrote: > This shall eliminate the need for bubblesorting of commands at runtime. > Every command definition structure is now put into it's own subsection > of section .u_boot_cmd, that is .u_boot_cmd. . These are then put > into .u_boot_cmd by linker and lastly, linker uses SORT() over these > subsections to make proper order on them. This shall eliminate some > runtime overhead. > > Signed-off-by: Marek Vasut > Cc: Wolfgang Denk > Cc: Mike Frysinger > --- > arch/arm/cpu/u-boot.lds | 2 +- > common/cmd_help.c | 2 +- > include/command.h | 9 ++++++--- > 3 files changed, 8 insertions(+), 5 deletions(-) Seems incomplete in several aspects: 1) what about all the non-ARM architecures and the board specific linker scripts? 2) what about removing the sort code? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Men of peace usually are [brave]. -- Spock, "The Savage Curtain", stardate 5906.5