From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build Date: Sat, 28 Jul 2012 12:55:35 -0700 Message-ID: <20120728195535.GC4762@kroah.com> References: <20120727103455.GA4639@merkur.ravnborg.org> <1693394101.5749000.1343409643934.JavaMail.root@vmware.com> <20120727181639.GA23564@kroah.com> <20120727202926.GC8262@dtor-ws.eng.vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20120727202926.GC8262@dtor-ws.eng.vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Dmitry Torokhov Cc: pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, vm-crosstalk@vmware.com, Andrew Stiegmann , Sam Ravnborg List-Id: virtualization@lists.linuxfoundation.org On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: > On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > > The kernel style is to use lower_case for everything. > > > > So this would become: > > > > > > > > vmci_device_get() > > > > > > > > This is obviously a very general comment and applies everywhere. > > > > > > I wish I could lower case these symbols but VMCI has already existed > > > outside the mainline Linux tree for some time now and changing these > > > exported symbols would mean that other drivers that depend on VMCI > > > (vSock, vmhgfs) would need to change as well. One thought that did > > > come to mind was exporting both VMCI_Device_Get and vmci_device_get > > > but that would likely just confuse people. So in short I have made > > > function names lower case where possible, but exported symbols could > > > not be changed. > > > > Not true at all. You want those drivers to be merged as well, right? > > So they will need to have their functions changed, and their code as > > well. > > > > Just wait until we get to the "change your functionality around" > > requests, those will require those drivers to change. Right now we are > > at the "silly and obvious things you did wrong" stage of the review > > process :) > > > > So please fix these, and also, post these drivers as well, so we can see > > how they interact with the core code. > > > > Actually, if you are going to need lots of refactoring for these > > drivers, and the core, I would recommend putting this all in the staging > > tree, to allow that to happen over time. That would ensure that your > > users keep having working systems, and let you modify the interfaces > > better and easier, than having to keep it all out-of-tree. > > > > What do you think? > > Actually I think that we'd prefer to keep this in a patch-based form, at > least for now, because majority of our users get these drivers with > VMware Tools and will continue doing so until ditsributions start > enabling VMCI in their kernels. Which they probably won't until VMCI > moves form staging. We'd also have to constantly adjust drivers that we > are not working on getting upstream at this time to work with the > rapidly changing version of VMCI in staging, which will just add work > for us. That wouldn't be an issue if you just include all of the drivers in the tree at the same time, right? Just like what the hyper-v developers did. greg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753089Ab2G1Tzl (ORCPT ); Sat, 28 Jul 2012 15:55:41 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:33070 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753032Ab2G1Tzj (ORCPT ); Sat, 28 Jul 2012 15:55:39 -0400 Date: Sat, 28 Jul 2012 12:55:35 -0700 From: Greg KH To: Dmitry Torokhov Cc: Andrew Stiegmann , pv-drivers@vmware.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, vm-crosstalk@vmware.com, Sam Ravnborg Subject: Re: [Pv-drivers] [vmw_vmci 11/11] Apply the header code to make VMCI build Message-ID: <20120728195535.GC4762@kroah.com> References: <20120727103455.GA4639@merkur.ravnborg.org> <1693394101.5749000.1343409643934.JavaMail.root@vmware.com> <20120727181639.GA23564@kroah.com> <20120727202926.GC8262@dtor-ws.eng.vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120727202926.GC8262@dtor-ws.eng.vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2012 at 01:29:27PM -0700, Dmitry Torokhov wrote: > On Fri, Jul 27, 2012 at 11:16:39AM -0700, Greg KH wrote: > > On Fri, Jul 27, 2012 at 10:20:43AM -0700, Andrew Stiegmann wrote: > > > > The kernel style is to use lower_case for everything. > > > > So this would become: > > > > > > > > vmci_device_get() > > > > > > > > This is obviously a very general comment and applies everywhere. > > > > > > I wish I could lower case these symbols but VMCI has already existed > > > outside the mainline Linux tree for some time now and changing these > > > exported symbols would mean that other drivers that depend on VMCI > > > (vSock, vmhgfs) would need to change as well. One thought that did > > > come to mind was exporting both VMCI_Device_Get and vmci_device_get > > > but that would likely just confuse people. So in short I have made > > > function names lower case where possible, but exported symbols could > > > not be changed. > > > > Not true at all. You want those drivers to be merged as well, right? > > So they will need to have their functions changed, and their code as > > well. > > > > Just wait until we get to the "change your functionality around" > > requests, those will require those drivers to change. Right now we are > > at the "silly and obvious things you did wrong" stage of the review > > process :) > > > > So please fix these, and also, post these drivers as well, so we can see > > how they interact with the core code. > > > > Actually, if you are going to need lots of refactoring for these > > drivers, and the core, I would recommend putting this all in the staging > > tree, to allow that to happen over time. That would ensure that your > > users keep having working systems, and let you modify the interfaces > > better and easier, than having to keep it all out-of-tree. > > > > What do you think? > > Actually I think that we'd prefer to keep this in a patch-based form, at > least for now, because majority of our users get these drivers with > VMware Tools and will continue doing so until ditsributions start > enabling VMCI in their kernels. Which they probably won't until VMCI > moves form staging. We'd also have to constantly adjust drivers that we > are not working on getting upstream at this time to work with the > rapidly changing version of VMCI in staging, which will just add work > for us. That wouldn't be an issue if you just include all of the drivers in the tree at the same time, right? Just like what the hyper-v developers did. greg