From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function
Date: Sat, 28 Jul 2012 22:59:48 +0200 [thread overview]
Message-ID: <201207282259.48776.marex@denx.de> (raw)
In-Reply-To: <20120728195733.28626200346@gemini.denx.de>
Dear Wolfgang Denk,
> Dear Marek Vasut,
>
> In message <201207282139.05998.marex@denx.de> you wrote:
> > > > include/common.h | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > >
> > > We have similar things already, and we don't add dead code - you add a
> > > macro without users here.
> >
> > It's used in 2/2 ... what macro do you have in mind ?
>
> Then add it with the patch that uses it.
I really wanted to keep this one separate, but I'll bend here. But if you
mention those xstr()s below, it might be actually better to add __stringify()
and then replace all those crazy xstr()s.
> As for existing use, see for example
[...]
> include/configs/ima3-mx53.h:#define xstr(s) str(s)
Thanks for pointing this out.
> > > If you want to unify the use of such a macro, fine - but then please
> > > replace all ocurrences of equivalent definitions all over the code.
>
> All these above (and any I eventually didn't find) should be replaced,
> then.
Good.
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-28 20:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-28 13:47 [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Marek Vasut
2012-07-28 13:47 ` [U-Boot] [RFC] [PATCH 2/2] crazy: Sort u_boot_cmd at runtime Marek Vasut
2012-07-28 17:46 ` Wolfgang Denk
2012-07-28 18:39 ` Marek Vasut
2012-07-28 19:53 ` Wolfgang Denk
2012-07-28 20:54 ` Marek Vasut
2012-07-28 19:36 ` [U-Boot] [PATCH 1/2] COMMON: Add __stringify() function Wolfgang Denk
2012-07-28 19:39 ` Marek Vasut
2012-07-28 19:57 ` Wolfgang Denk
2012-07-28 20:59 ` Marek Vasut [this message]
2012-07-31 8:01 ` Mike Frysinger
2012-07-31 13:55 ` Marek Vasut
2012-07-31 14:06 ` Mike Frysinger
2012-07-31 14:08 ` Marek Vasut
2012-07-31 14:16 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207282259.48776.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.