From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/8 v2] ARM: EXYNOS5: Add machine data for USB 2.0 Date: Sun, 29 Jul 2012 13:11:07 +0000 Message-ID: <201207291311.08012.arnd@arndb.de> References: <1342866729-30460-1-git-send-email-gautam.vivek@samsung.com> <201207261124.50141.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.187]:60788 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753363Ab2G2UYL (ORCPT ); Sun, 29 Jul 2012 16:24:11 -0400 In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Vivek Gautam Cc: linux-arm-kernel@lists.infradead.org, l.majewski@samsung.com, kgene.kim@samsung.com, boyko.lee@samsung.com, devicetree-discuss@lists.ozlabs.org, yulgon.kim@samsung.com, joshi@samsung.com, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, Vivek Gautam , olofj@google.com, a.kesavan@samsung.com, av.tikhomirov@samsung.com, prashanth.g@samsung.com, ajaykumar.rs@samsung.com, m.szyprowski@samsung.com On Saturday 28 July 2012, Vivek Gautam wrote: > > Can you pleae explain why this is done in the changelog? > > > > We try hard to do such mappings from the device driver instead, > > so I'm surprised that this is necessary fo rthe USB phy. > > > > We are doing the mapping for device address in the driver, but this memory > mapping for USB PHY registers that need to be programmed by the software > is done here. This is similar to what we see for exynos4 also. Is it > something > that i can still change? Please suggest. Yes, I think the USB PHY handling for all exynos chips should be changed from an ad-hoc method to a more formal device driver. As I commented in another patch of this series, I think the main problem is that treat the USB PHY as a property of the "platform", which it really isn't. We have a bunch of other USB PHY drivers for other platforms that are inside of the drivers/usb hierarchy. For all I know, there is no formal USB PHY driver API yet, and it seems that it would be a good idea to introduce one now, but for now, just move the code to drivers/usb/phy/ and make it one file per different kind of PHY. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Sun, 29 Jul 2012 13:11:07 +0000 Subject: [PATCH 2/8 v2] ARM: EXYNOS5: Add machine data for USB 2.0 In-Reply-To: References: <1342866729-30460-1-git-send-email-gautam.vivek@samsung.com> <201207261124.50141.arnd@arndb.de> Message-ID: <201207291311.08012.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Saturday 28 July 2012, Vivek Gautam wrote: > > Can you pleae explain why this is done in the changelog? > > > > We try hard to do such mappings from the device driver instead, > > so I'm surprised that this is necessary fo rthe USB phy. > > > > We are doing the mapping for device address in the driver, but this memory > mapping for USB PHY registers that need to be programmed by the software > is done here. This is similar to what we see for exynos4 also. Is it > something > that i can still change? Please suggest. Yes, I think the USB PHY handling for all exynos chips should be changed from an ad-hoc method to a more formal device driver. As I commented in another patch of this series, I think the main problem is that treat the USB PHY as a property of the "platform", which it really isn't. We have a bunch of other USB PHY drivers for other platforms that are inside of the drivers/usb hierarchy. For all I know, there is no formal USB PHY driver API yet, and it seems that it would be a good idea to introduce one now, but for now, just move the code to drivers/usb/phy/ and make it one file per different kind of PHY. Arnd