From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Date: Sun, 29 Jul 2012 21:42:18 +0100 Message-ID: <20120729204218.GI4384@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id F12E026031B for ; Sun, 29 Jul 2012 22:42:17 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1343393162-11938-6-git-send-email-lee.jones@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lee Jones Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, lrg@ti.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > + msp->use_pinctrl = true; > + else > + msp->use_pinctrl = false; I don't recall seeing any response to my query about this on the first iteration. Please don't just ignore review comments. From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@opensource.wolfsonmicro.com (Mark Brown) Date: Sun, 29 Jul 2012 21:42:18 +0100 Subject: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree In-Reply-To: <1343393162-11938-6-git-send-email-lee.jones@linaro.org> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> Message-ID: <20120729204218.GI4384@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > + msp->use_pinctrl = true; > + else > + msp->use_pinctrl = false; I don't recall seeing any response to my query about this on the first iteration. Please don't just ignore review comments. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753573Ab2G2UmW (ORCPT ); Sun, 29 Jul 2012 16:42:22 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:51310 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454Ab2G2UmU (ORCPT ); Sun, 29 Jul 2012 16:42:20 -0400 Date: Sun, 29 Jul 2012 21:42:18 +0100 From: Mark Brown To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, lrg@ti.com Subject: Re: [PATCH 05/18] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Message-ID: <20120729204218.GI4384@opensource.wolfsonmicro.com> References: <1343393162-11938-1-git-send-email-lee.jones@linaro.org> <1343393162-11938-6-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1343393162-11938-6-git-send-email-lee.jones@linaro.org> X-Cookie: You dialed 5483. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 27, 2012 at 01:45:49PM +0100, Lee Jones wrote: > + if (of_get_property(np, "stericsson,use-pinctrl", NULL)) > + msp->use_pinctrl = true; > + else > + msp->use_pinctrl = false; I don't recall seeing any response to my query about this on the first iteration. Please don't just ignore review comments.