From: Dave Chinner <david@fromorbit.com>
To: Wanlong Gao <gaowanlong@cn.fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>, Ben Myers <bpm@sgi.com>,
Zach Brown <zab@zabbo.net>,
xfs@oss.sgi.com
Subject: Re: [PATCH V7] xfs: cleanup the mount options
Date: Mon, 30 Jul 2012 08:09:09 +1000 [thread overview]
Message-ID: <20120729220909.GC2877@dastard> (raw)
In-Reply-To: <1343178697-3479-1-git-send-email-gaowanlong@cn.fujitsu.com>
On Wed, Jul 25, 2012 at 09:11:37AM +0800, Wanlong Gao wrote:
> remove the mount options macro, use tokens instead.
>
> change from V6: (Dave)
> 1. switch GFP_NOFS to GFP_KERNEL
>
> change from V5: (Dave)
> 1. fix a string leak.
> 2. leave the show options to raw numbers.
>
> change from V4: (as Dave suggested)
> 1. suffix_match_int avoid overflow.
> 2. convert the return style to be consistent with others.
> 3. move the "intarg" init above the switch.
> 4. move match_strdup to a help function.
> 5. collapsed Opt_biosize and Opt_allocsize.
> 6. make a consistent deprecated message.
Looks good now. Thanks for takingthe time to get this right!
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-29 22:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 16:57 [PATCH] xfs: cleanup the mount options Wanlong Gao
2012-06-27 17:44 ` Christoph Hellwig
2012-06-28 0:54 ` Wanlong Gao
2012-06-28 16:01 ` Ben Myers
2012-06-28 16:33 ` Zach Brown
2012-06-28 19:54 ` Carlos Maiolino
2012-06-29 1:00 ` Wanlong Gao
2012-06-29 16:29 ` Zach Brown
2012-06-29 16:37 ` Wanlong Gao
2012-06-29 18:06 ` [PATCH 1/2 V2] " Wanlong Gao
2012-06-29 18:06 ` [PATCH 2/2] xfs: rename xfs_fs_* to xfs_* Wanlong Gao
2012-07-01 23:47 ` Dave Chinner
2012-07-02 0:39 ` Wanlong Gao
2012-07-02 6:26 ` [PATCH 1/2 V2] xfs: cleanup the mount options Christoph Hellwig
2012-07-02 7:05 ` [PATCH V3] " Wanlong Gao
2012-07-06 3:05 ` Dave Chinner
2012-07-08 11:36 ` [PATCH V4] " Wanlong Gao
2012-07-09 0:22 ` Dave Chinner
2012-07-09 9:21 ` Wanlong Gao
2012-07-11 2:26 ` Dave Chinner
2012-07-11 6:29 ` [PATCH V5] " Wanlong Gao
2012-07-16 8:06 ` Wanlong Gao
2012-07-23 20:33 ` Ben Myers
2012-07-23 23:28 ` Dave Chinner
2012-07-24 2:01 ` Wanlong Gao
2012-07-24 21:18 ` Dave Chinner
2012-07-25 1:09 ` Wanlong Gao
2012-07-25 1:11 ` [PATCH V7] " Wanlong Gao
2012-07-29 22:09 ` Dave Chinner [this message]
2012-08-28 19:38 ` Ben Myers
2012-07-24 2:10 ` [PATCH V6] " Wanlong Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120729220909.GC2877@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=gaowanlong@cn.fujitsu.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.