All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH] stubdom: fix errors in newlib [and 1 more messages]
Date: Mon, 30 Jul 2012 20:44:13 +0200	[thread overview]
Message-ID: <20120730184413.GB3155@aepfle.de> (raw)
In-Reply-To: <20494.46436.198238.49567@mariner.uk.xensource.com>

On Tue, Jul 24, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH] stubdom: fix errors in newlib"):
> > stubdom: fix errors in newlib
> 
> Well, I agree with Ian's reservations about this:
> 
> Ian Campbell writes ("Re: [Xen-devel] [PATCH] stubdom: fix errors in newlib"):
> > On Tue, 2012-07-10 at 12:12 -0400, Olaf Hering wrote:
> > > # HG changeset patch
> > > # User Olaf Hering <olaf@aepfle.de>
> > > # Date 1341839122 -7200
> > > # Node ID 2dd50c201ca0d3542f3589942ae9e51d33ec7509
> > > # Parent  42f76d536b116d2ebad1b6705ae51ecd171d2581
> > > stubdom: fix errors in newlib
> > > 
> > > rpmlint found a few code bugs in newlib, and marks them as errors after
> > > rpm build. Add another newlib patch and apply it during stubdom build.
> > 
> > Are any of these specific to Xen or should they really be being sent to
> > newlib upstream? (we could really do with resyncing on he latest newlib
> > and sending or our patches again it. In our CFT of course ;-))
> 
> I definitely don't think we should be trying to drain the swamp of
> newlib's bad code in our own tree.
> 
> The right answer for your rpm checks is probably to disable them
> somehow.  These are very likely to be real security problems in the
> context of stubdomains.

I tried newlib 1.20, which seems to emit no such warnings. However
building stubdom with the newer version leads to link errors. I havent
spent time yet to find a fix for those failures.

Now that rc1 is out, its probably much too late to go for a more recent
newlib to get around the build failures in current code?

Olaf

  parent reply	other threads:[~2012-07-30 18:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-10 16:12 [PATCH] stubdom: fix errors in newlib Olaf Hering
2012-07-10 16:59 ` Ian Campbell
2012-07-10 18:02   ` Olaf Hering
2012-07-10 20:51   ` Olaf Hering
2012-07-24 14:47   ` [PATCH] stubdom: fix errors in newlib [and 1 more messages] Ian Jackson
2012-07-24 14:48     ` Ian Campbell
2012-07-24 14:49       ` Ian Jackson
2012-07-30 18:44     ` Olaf Hering [this message]
2012-07-30 18:45       ` Ian Campbell
2012-07-12  7:56 ` [PATCH] stubdom: fix errors in newlib Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120730184413.GB3155@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.