All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script
Date: Tue, 31 Jul 2012 07:56:30 +1000	[thread overview]
Message-ID: <20120730215630.GH2877@dastard> (raw)
In-Reply-To: <1343649811-13944-1-git-send-email-tracek@redhat.com>

On Mon, Jul 30, 2012 at 02:03:31PM +0200, Tomas Racek wrote:
> 
> Signed-off-by: Tomas Racek <tracek@redhat.com>
> ---
>  common.config |   26 ++++++++++++++------------
>  1 files changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/common.config b/common.config
> index 7bed1c5..b92c025 100644
> --- a/common.config
> +++ b/common.config
> @@ -201,9 +201,9 @@ known_hosts()
> 
>    #  Mandatory Config values.
>    MC=""
> -  [ -z "$EMAIL" ]          && MC="$MC EMAIL"
> -  [ -z "$TEST_DIR" ]       && MC="$MC TEST_DIR"
> -  [ -z "$TEST_DEV" ]       && MC="$MC TEST_DEV"
> +  [ -z "$EMAIL" ]                           && MC="$MC EMAIL"
> +  [ -z "$TEST_DIR" ] && [ "$iam" != "new" ] && MC="$MC TEST_DIR"
> +  [ -z "$TEST_DEV" ] && [ "$iam" != "new" ] && MC="$MC TEST_DEV"

Given that I'm currently in the process of killing $iam as I
rework the structure of xfstests, I really don't like the idea of
introducing new dependencies on it.

Also, I prefer to know that someone writing a new test is developing
it in a configured, working test environment. After all, you have to
test your new test as you write it... :p

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-30 21:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-30 12:03 [PATCH] xfstests: Don't require to set $TEST_DEV and $TEST_DIR when creating new script Tomas Racek
2012-07-30 21:56 ` Dave Chinner [this message]
2012-07-31 10:41   ` Tomas Racek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120730215630.GH2877@dastard \
    --to=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=tracek@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.