From: Marek Vasut <marex@denx.de>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH RESEND] mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver
Date: Tue, 31 Jul 2012 06:17:06 +0200 [thread overview]
Message-ID: <201207310617.06974.marex@denx.de> (raw)
In-Reply-To: <1343696537-2564-1-git-send-email-computersforpeace@gmail.com>
Dear Brian Norris,
> The NAND_CHIPOPTIONS_MSK has limited utility and is causing real bugs. It
> silently masks off at least one flag that might be set by the driver
> (NAND_NO_SUBPAGE_WRITE). This breaks the GPMI NAND driver and possibly
> others.
>
> Really, as long as driver writers exercise a small amount of care with
> NAND_* options, this mask is not necessary at all. Thus, kill it.
>
> From Huang Shijie:
>
> "I tested this patch on imx6q-arm2 board with Micron MT29F32G08QAA.
> it works fine, thanks."
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> Tested-by: Huang Shijie <shijie8@gmail.com>
Tested-by: Marek Vasut <marex@denx.de>
Sorry for the slow reply. Tested it on denx m28evk board.
> Cc: Marek Vasut <marex@denx.de>
> ---
> Hello Artem/David,
>
> GPMI NAND has needed this patch for some time, and I think it was agreed
> on by a few. I'm resending to get acknowledgment from a maintainer.
[...]
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-07-31 4:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 1:02 [PATCH RESEND] mtd: nand: allow NAND_NO_SUBPAGE_WRITE to be set from driver Brian Norris
2012-07-31 4:17 ` Marek Vasut [this message]
2012-07-31 7:33 ` Matthieu CASTET
2012-07-31 13:20 ` Marek Vasut
2012-07-31 13:28 ` Matthieu CASTET
2012-07-31 13:59 ` Marek Vasut
2012-07-31 14:09 ` Matthieu CASTET
2012-07-31 14:12 ` Marek Vasut
2012-07-31 16:11 ` Scott Wood
2012-08-01 2:21 ` Huang Shijie
2012-08-01 13:05 ` Matthieu CASTET
2012-08-01 16:15 ` Scott Wood
2012-08-02 1:08 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207310617.06974.marex@denx.de \
--to=marex@denx.de \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.