All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark van Dijk <lists+xen@internecto.net>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
Subject: Re: Kernel crash with acpi_processor, cpu_idle and intel_idle =y
Date: Wed, 1 Aug 2012 01:59:41 +0200	[thread overview]
Message-ID: <20120801015941.22f773d3@internecto.net> (raw)
In-Reply-To: <20120731134054.GD4789@phenom.dumpdata.com>

Message 20120731134054.GD4789@phenom.dumpdata.com contained:

>Duh! That is easy enough to fix. Mark, can you please try testing with
>this patch (and obviously enable the CONFIG_INTEL_IDLE)
>
>diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
>index d0f59c3..46a9884 100644
>--- a/drivers/idle/intel_idle.c
>+++ b/drivers/idle/intel_idle.c
>@@ -557,7 +557,7 @@ static int __init intel_idle_init(void)
> 	retval = cpuidle_register_driver(&intel_idle_driver);
> 	if (retval) {
> 		printk(KERN_DEBUG PREFIX "intel_idle yielding to %s",
>-			cpuidle_get_driver()->name);
>+			cpuidle_get_driver() ?
>cpuidle_get_driver()->name : "none");
> 		return retval;
> 	}
> 

Good going Jan and Konrad. The above patch works: no more crashes. For
fun I have also tested the patch from my previous email (the link to
the lkml, it has been acked so was worth a try). I tested it in
correlation with your patch and I still see no crashes.



-- 
Stay in touch,
Mark van Dijk.               ,--------------------------------
----------------------------'        Tue Jul 31 22:19 UTC 2012
Today is Pungenday, the 67th day of Confusion in the YOLD 3178

  parent reply	other threads:[~2012-07-31 23:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22 16:16 Kernel crash with acpi_processor, cpu_idle and intel_idle =y Mark van Dijk
2012-07-23 14:20 ` Konrad Rzeszutek Wilk
2012-07-26  0:25   ` Mark van Dijk
2012-07-26  7:15     ` Jan Beulich
2012-07-26 14:05     ` Konrad Rzeszutek Wilk
2012-07-26 14:57       ` Jan Beulich
2012-07-26 14:55         ` Konrad Rzeszutek Wilk
2012-07-28 12:55           ` Mark van Dijk
2012-07-30  7:45             ` Jan Beulich
2012-07-31 11:58               ` Mark van Dijk
2012-07-31 13:42                 ` Konrad Rzeszutek Wilk
2012-07-31 13:40               ` Konrad Rzeszutek Wilk
2012-07-31 21:50                 ` Mark van Dijk
2012-07-31 23:42                   ` Konrad Rzeszutek Wilk
2012-07-31 23:59                 ` Mark van Dijk [this message]
2012-07-31 23:55                   ` Konrad Rzeszutek Wilk
2012-08-01  0:25                     ` Mark van Dijk
2012-07-23 14:28 ` Jan Beulich
2012-07-26  0:30   ` Mark van Dijk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120801015941.22f773d3@internecto.net \
    --to=lists+xen@internecto.net \
    --cc=JBeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.