Re: perf: commit 44f24cb3156a1e (Factor DSO symtab types) causes segfaults

[Markus Trippelsdorf <markus@trippelsdorf.de>]

On 2012.07.31 at 16:14 +0200, Ingo Molnar wrote:
> Jiri Olsa (4):
>       perf symbols: Factor DSO symtab types to generic binary types

The commit above causes perf segfaults on my machine (running glibc trunk):

(gdb) run top --stdio
Starting program: /usr/src/linux/tools/perf/perf top --stdio
warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7ffff7ffa000
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
dso__load (dso=0x6661d0, map=map@entry=0x666170, filter=filter@entry=0x426840 <symbol_filter>) at util/symbol.c:1833
1833                    dso->symtab_type = binary_type_symtab[i];
(gdb) bt
#0  dso__load (dso=0x6661d0, map=map@entry=0x666170, filter=filter@entry=0x426840 <symbol_filter>) at util/symbol.c:1833
#1  0x000000000045fe87 in map__load (self=self@entry=0x666170, filter=filter@entry=0x426840 <symbol_filter>) at util/map.c:124
#2  0x000000000045ffbd in map__find_symbol (self=0x666170, addr=11008, filter=filter@entry=0x426840 <symbol_filter>) at util/map.c:168
#3  0x000000000043b5df in perf_event__preprocess_sample (event=event@entry=0x7ffff44c8720, machine=machine@entry=0x647730, 
    al=al@entry=0x7fffffffb030, sample=sample@entry=0x7fffffffb060, filter=filter@entry=0x426840 <symbol_filter>) at util/event.c:886
#4  0x0000000000426d8e in perf_event__process_sample (machine=0x647730, sample=0x7fffffffb060, evsel=<optimized out>, event=0x7ffff44c8720, 
    tool=0x7fffffffb2c0) at builtin-top.c:723
#5  perf_top__mmap_read_idx (top=top@entry=0x7fffffffb2c0, idx=idx@entry=3) at builtin-top.c:858
#6  0x00000000004291c3 in perf_top__mmap_read (top=<optimized out>) at builtin-top.c:873
#7  __cmd_top (top=0x7fffffffb2c0) at builtin-top.c:1040
#8  cmd_top (argc=<optimized out>, argv=<optimized out>, prefix=<optimized out>) at builtin-top.c:1348
#9  0x0000000000414d03 in run_builtin (p=p@entry=0x4dc888, argc=argc@entry=2, argv=argv@entry=0x7fffffffe0b0) at perf.c:273
#10 0x0000000000415487 in handle_internal_command (argv=0x7fffffffe0b0, argc=2) at perf.c:345
#11 run_argv (argv=0x7fffffffdeb0, argcp=0x7fffffffdebc) at perf.c:389
#12 main (argc=2, argv=0x7fffffffe0b0) at perf.c:487
(gdb)

44f24cb3156a1e7d2b6bb501b7f6153aed08994c is the first bad commit
commit 44f24cb3156a1e7d2b6bb501b7f6153aed08994c
Author: Jiri Olsa <jolsa@redhat.com>
Date:   Sun Jul 22 14:14:32 2012 +0200

    perf symbols: Factor DSO symtab types to generic binary types

-- 
Markus