From: Tino Reichardt <list-linux-fsdevel@mcmilk.de>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jfs-discussion@lists.sourceforge.net
Subject: Re: [Jfs-discussion] [PATCH] fs/jfs: TRIM support for JFS Filesystem
Date: Wed, 1 Aug 2012 22:08:29 +0200 [thread overview]
Message-ID: <20120801200829.GA30608@mcmilk.de> (raw)
In-Reply-To: <20120801192934.GB19139@mcmilk.de>
* Tino Reichardt <list-linux-fsdevel@mcmilk.de> wrote:
> * Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> > On 07/28/2012 06:08 AM, Tino Reichardt wrote:
> > > * Tino Reichardt <list-linux-fsdevel@mcmilk.de> wrote:
> > >> > This patch adds support for the two linux interfaces of the discard/TRIM
> > >> > command for SSD devices and sparse/thinly-provisioned LUNs.
> > > Fixed a problem when setting minlen in jfs_ioc_trim().
Oops, setting minlen in jfs_ioc_trim() was again wrong :/
I changed this
if (minlen < 0)
minlen = 1;
to this:
if (minlen <= 0)
minlen = 1;
This is important, since fstrim() sets it to zero.
Fully working patch is located here:
http://www.mcmilk.de/projects/jfs-trim/linux-tree/jfs-trim-2012-08-01_v2.diff
Signed-off-by: Tino Reichardt <list-jfs@mcmilk.de>
--
regards, TR
next prev parent reply other threads:[~2012-08-01 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 21:32 [PATCH] fs/jfs: TRIM support for JFS Filesystem Tino Reichardt
2012-07-28 11:08 ` Tino Reichardt
2012-07-31 22:15 ` Dave Kleikamp
2012-07-31 22:15 ` [Jfs-discussion] " Dave Kleikamp
2012-08-01 19:29 ` Tino Reichardt
2012-08-01 20:07 ` Dave Kleikamp
2012-08-01 20:08 ` Tino Reichardt [this message]
2012-08-06 16:59 ` Tino Reichardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120801200829.GA30608@mcmilk.de \
--to=list-linux-fsdevel@mcmilk.de \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.