From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Date: Thu, 2 Aug 2012 13:21:03 +0100 Message-ID: <20120802122101.GA22228@gmail.com> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id D9DBD265202 for ; Thu, 2 Aug 2012 14:21:04 +0200 (CEST) Received: by eeke50 with SMTP id e50so1884424eek.38 for ; Thu, 02 Aug 2012 05:21:07 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1343741493-17671-3-git-send-email-lee.jones@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, linus.walleij@stericsson.com, arnd@arndb.de, broonie@opensource.wolfsonmicro.com, olalilja@yahoo.se, STEricsson_nomadik_linux@list.st.com, lrg@ti.com List-Id: alsa-devel@alsa-project.org UGF0Y2ggd2l0aGRyYXduLgoKT24gVHVlLCBKdWwgMzEsIDIwMTIgYXQgMDI6MzE6MjNQTSArMDEw MCwgTGVlIEpvbmVzIHdyb3RlOgo+IElmIGEgbGlzdCBvZiB3aWRnZXRzIGlzIHByb3ZpZGVkIGFu ZCBvbmUgb2YgdGhlbSBmYWlscyB0byBiZSBhZGRlZCBhcwo+IGEgY29udHJvbCwgdGhlIHByZXNl bnQgc2VtYW50aWNzIGZhaWwgYWxsIHN1YnNlcXVlbnQgd2lkZ2V0cy4gQSBiZXR0ZXIKPiBzb2x1 dGlvbiB3b3VsZCBiZSB0byBvbmx5IGZhaWwgdGhhdCB3aWRnZXQsIGJ1dCBwdXJzdWUgaW4gYXR0 ZW1wdGluZwo+IHRvIGFkZCB0aGUgcmVzdCBvZiB0aGUgbGlzdC4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBzb3VuZC9zb2Mvc29j LWRhcG0uYyB8ICAgIDIgLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9zb2MtZGFwbS5jIGIvc291bmQvc29jL3NvYy1kYXBtLmMK PiBpbmRleCBlZGVkNjU3Li43ZDljMTU0IDEwMDY0NAo+IC0tLSBhL3NvdW5kL3NvYy9zb2MtZGFw bS5jCj4gKysrIGIvc291bmQvc29jL3NvYy1kYXBtLmMKPiBAQCAtMzA5NSw4ICszMDk1LDYgQEAg aW50IHNuZF9zb2NfZGFwbV9uZXdfY29udHJvbHMoc3RydWN0IHNuZF9zb2NfZGFwbV9jb250ZXh0 ICpkYXBtLAo+ICAJCQlkZXZfZXJyKGRhcG0tPmRldiwKPiAgCQkJCSJBU29DOiBGYWlsZWQgdG8g Y3JlYXRlIERBUE0gY29udHJvbCAlc1xuIiwKPiAgCQkJCXdpZGdldC0+bmFtZSk7Cj4gLQkJCXJl dCA9IC1FTk9NRU07Cj4gLQkJCWJyZWFrOwo+ICAJCX0KPiAgCQl3aWRnZXQrKzsKPiAgCX0KPiAt LSAKPiAxLjcuOS41Cj4gCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5n IFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNv Q3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlz dApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0 Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Thu, 2 Aug 2012 13:21:03 +0100 Subject: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too In-Reply-To: <1343741493-17671-3-git-send-email-lee.jones@linaro.org> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> Message-ID: <20120802122101.GA22228@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Patch withdrawn. On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: > If a list of widgets is provided and one of them fails to be added as > a control, the present semantics fail all subsequent widgets. A better > solution would be to only fail that widget, but pursue in attempting > to add the rest of the list. > > Signed-off-by: Lee Jones > --- > sound/soc/soc-dapm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > index eded657..7d9c154 100644 > --- a/sound/soc/soc-dapm.c > +++ b/sound/soc/soc-dapm.c > @@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm, > dev_err(dapm->dev, > "ASoC: Failed to create DAPM control %s\n", > widget->name); > - ret = -ENOMEM; > - break; > } > widget++; > } > -- > 1.7.9.5 > -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754007Ab2HBMVJ (ORCPT ); Thu, 2 Aug 2012 08:21:09 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:52800 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753449Ab2HBMVI (ORCPT ); Thu, 2 Aug 2012 08:21:08 -0400 Date: Thu, 2 Aug 2012 13:21:03 +0100 From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: STEricsson_nomadik_linux@list.st.com, linus.walleij@stericsson.com, arnd@arndb.de, olalilja@yahoo.se, ola.o.lilja@stericsson.com, alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com, lrg@ti.com Subject: Re: [PATCH 1/6] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Message-ID: <20120802122101.GA22228@gmail.com> References: <1343741493-17671-1-git-send-email-lee.jones@linaro.org> <1343741493-17671-3-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1343741493-17671-3-git-send-email-lee.jones@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch withdrawn. On Tue, Jul 31, 2012 at 02:31:23PM +0100, Lee Jones wrote: > If a list of widgets is provided and one of them fails to be added as > a control, the present semantics fail all subsequent widgets. A better > solution would be to only fail that widget, but pursue in attempting > to add the rest of the list. > > Signed-off-by: Lee Jones > --- > sound/soc/soc-dapm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c > index eded657..7d9c154 100644 > --- a/sound/soc/soc-dapm.c > +++ b/sound/soc/soc-dapm.c > @@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm, > dev_err(dapm->dev, > "ASoC: Failed to create DAPM control %s\n", > widget->name); > - ret = -ENOMEM; > - break; > } > widget++; > } > -- > 1.7.9.5 > -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog