Re: RE: [PATCH] scsi/mvsas: Fix oops when ata command timeout.

[majianpeng <majianpeng@gmail.com>]

On 2012-08-01 19:21 Xiangliang Yu <yuxiangl@marvell.com> Wrote:
>Hi, Jianpeng
>
>I think MVSAS shouldn't care the completion sign here, just modify task state is ok.
>
>
>
[snip]
>> 
>> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
>> ---
>>  drivers/scsi/mvsas/mv_sas.c |    5 ++++-
>>  1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
>> index 4539d59..af6a1c5 100644
>> --- a/drivers/scsi/mvsas/mv_sas.c
>> +++ b/drivers/scsi/mvsas/mv_sas.c
>> @@ -1629,7 +1629,10 @@ int mvs_abort_task(struct sas_task *task)
>>  			mv_dprintk("mvs_abort_task() mvi=%p task=%p "
>>  				   "slot=%p slot_idx=x%x\n",
>>  				   mvi, task, slot, slot_idx);
>> -			mvs_tmf_timedout((unsigned long)task);
>> +			if (task->slow_task != NULL)
>> +				mvs_tmf_timedout((unsigned long)task);
>> +			else
>> +				task->task_state_flags |= SAS_TASK_STATE_ABORTED;
>>  			mvs_slot_task_free(mvi, task, slot, slot_idx);
>>  			rc = TMF_RESP_FUNC_COMPLETE;
>>  			goto out;
>> --
>> 1.7.9.5
Thanks, I'll modify the code and resend.