Re: [NEW DRIVER V1 4/7] DA9058 RTC driver

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Thu, Aug 02, 2012 at 09:48:56AM +0100, Anthony Olech wrote:

> -comment "I2C RTC drivers"
> -	depends on I2C
> -
> -if I2C
> -
>  config RTC_DRV_88PM860X
>  	tristate "Marvell 88PM860x"
>  	depends on RTC_CLASS && I2C && MFD_88PM860X
> @@ -135,6 +130,21 @@ config RTC_DRV_88PM860X
>  	  This driver can also be built as a module. If so, the module
>  	  will be called rtc-88pm860x.
>  
> +comment "I2C RTC drivers"
> +	depends on I2C
> +
> +if I2C
> +

Hrm?

> +	dev_info(dev, "Read RTC: %02x %02x %02x %02x %02x %02x\n",
> +		rtc_time[0], rtc_time[1], rtc_time[2],
> +		rtc_time[3], rtc_time[4], rtc_time[5]);

This is way too noisy to be doing every time you read the RTC.

> +	dev_info(dev, "Setting RTC: %02x %02x %02x %02x %02x %02x\n",
> +		rtc_time[0], rtc_time[1], rtc_time[2], rtc_time[3],
> +		rtc_time[4], rtc_time[5]);

Similarly here...

> +	ret = da9058_bulk_write(da9058, DA9058_COUNTS_REG, rtc_time, 6);
> +	if (ret) {
> +		dev_dbg(dev, "failed %d to write to RTC\n", ret);

...especially given that things like actual error messages are at debug
level!

> +static int da9058_rtc_proc(struct device *dev, struct seq_file *seq)
> +{
> +	seq_printf(seq, "Tony Olech was here\n");
> +
> +	return 0;
> +}

Perhaps the driver needs some cleanup...