From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Thu, 2 Aug 2012 23:28:16 +0000 Subject: am33xx: default to status = "disabled"? In-Reply-To: <501B061A.6080008@gmail.com> References: <501B061A.6080008@gmail.com> Message-ID: <201208022328.17095.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 02 August 2012, Daniel Mack wrote: > currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by > default. However, depending on the actual board dts, only some of the > devices should actually be initialized, given that they only make sense > if their pins are actually wired on the board. > > On other platform, such devices are marked with status = "disabled", and > the board files re-enable those they really use by overriding that > status again. That approach seems to make sense - shouldn't the same be > done in am33xx.dtsi or am I missing something? I agree, they should be disabled, at least the serial ports, and probably also the i2c controllers. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: am33xx: default to status = "disabled"? Date: Thu, 2 Aug 2012 23:28:16 +0000 Message-ID: <201208022328.17095.arnd@arndb.de> References: <501B061A.6080008@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <501B061A.6080008-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Daniel Mack Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Koen Kooi , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Thursday 02 August 2012, Daniel Mack wrote: > currently, all devices in arch/arm/boot/dts/am33xx.dtsi are enabled by > default. However, depending on the actual board dts, only some of the > devices should actually be initialized, given that they only make sense > if their pins are actually wired on the board. > > On other platform, such devices are marked with status = "disabled", and > the board files re-enable those they really use by overriding that > status again. That approach seems to make sense - shouldn't the same be > done in am33xx.dtsi or am I missing something? I agree, they should be disabled, at least the serial ports, and probably also the i2c controllers. Arnd