From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [RFC PATCH 3/5] drm/i915: register LVDS connector even if we can't get a panel mode Date: Fri, 3 Aug 2012 17:14:16 +0100 Message-ID: <20120803161416.GA22563@srcf.ucam.org> References: <1344009741-14248-1-git-send-email-seth.forshee@canonical.com> <1344009741-14248-4-git-send-email-seth.forshee@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1344009741-14248-4-git-send-email-seth.forshee@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Seth Forshee Cc: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , linux-kernel@vger.kernel.org, Andreas Heider List-Id: dri-devel@lists.freedesktop.org On Fri, Aug 03, 2012 at 11:02:19AM -0500, Seth Forshee wrote: > Some Apple hybrid graphics machines do not have the LVDS panel connected > to the integrated GPU at boot and also do not supply a VBT. The LVDS > connector is not registered as a result, making it impossible to support > graphics switching. > > This patch changes intel_lvds_init() to register the connector even if > we can't find any panel modes. This makes it necessary to always check > intel_lvds->fixed_mode before use, as it could now be NULL. This one kind of sucks. I think adding a quirk for this situation would be justifiable, rather than doing it for all devices. -- Matthew Garrett | mjg59@srcf.ucam.org