From: Dan Carpenter <dan.carpenter@oracle.com>
To: arend@broadcom.com
Cc: linux-wireless@vger.kernel.org
Subject: re: net: wireless: add brcm80211 drivers
Date: Sun, 5 Aug 2012 22:57:16 +0300 [thread overview]
Message-ID: <20120805195716.GA12400@elgon.mountain> (raw)
Hi Arend,
The patch 5b435de0d786: "net: wireless: add brcm80211 drivers" from
Oct 5, 2011, leads to the following warning:
drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:1699 brcmf_sdbrcm_readframes()
warn: is it ok to set 'rxseq' to -1?
1697 cnt = brcmf_sdbrcm_rxglom(bus, rxseq);
1698 brcmf_dbg(GLOM, "rxglom returned %d\n", cnt);
1699 rxseq += cnt - 1;
1700 rxleft = (rxleft > cnt) ? (rxleft - cnt) : 1;
1701 continue;
This isn't a warning, it's just one of the things I audit.
brcmf_sdbrcm_rxglom() can return 0 so it's weird that we do
"rxseq += 0 - 1;" Was that intended?
regards,
dan carpenter
next reply other threads:[~2012-08-05 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 19:57 Dan Carpenter [this message]
2012-08-06 8:50 ` net: wireless: add brcm80211 drivers Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2016-06-27 13:22 Dan Carpenter
2016-06-27 19:12 ` Dan Carpenter
2012-05-13 17:43 Dan Carpenter
2012-05-14 7:07 ` Arend van Spriel
2012-05-14 8:34 ` Dan Carpenter
2012-05-14 9:06 ` Arend van Spriel
2012-05-14 9:28 ` Dan Carpenter
2012-05-14 11:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120805195716.GA12400@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.