diff for duplicates of <20120806000157.GA10971@bbox> diff --git a/a/1.txt b/N1/1.txt index 30241a4..c6e3cf5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -113,3 +113,67 @@ I am not sure I send this patch to whom, Linus or Andrew? Anyway, Please use below if really need it. Thanks! + +>From b575b78a1ba7daf7a9adc3b49dadfbd573be398d Mon Sep 17 00:00:00 2001 +From: Minchan Kim <minchan@kernel.org> +Date: Mon, 6 Aug 2012 08:57:57 +0900 +Subject: [PATCH] mm: fix wrong warning check for detect pgdat's garbage + +[1] added some check for pgdat garbage but Borislav reported +the warning happens in 4-node AMD system. + +The problem is that node_start_pfn is initialized doublely +in arch code and generic mm code. Normally, pgdat's members +are closely related to arch boot code so it's not good idea +to check such members in generic mm code. + +So this patch removes node_start_pfn check and leave other +variable check as it is because nr_zone and classzone_idx +should be initialized by generic mm code, NOT arch code so +it would never happen problem. + +[1] 88fdf75d, mm: warn if pg_data_t isn't initialized with zero + +Reporeted-by: Borislav Petkov <bp@amd64.org> +Signed-off-by: Minchan Kim <minchan@kernel.org> +--- + mm/page_alloc.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mm/page_alloc.c b/mm/page_alloc.c +index 889532b..009ac28 100644 +--- a/mm/page_alloc.c ++++ b/mm/page_alloc.c +@@ -4511,7 +4511,7 @@ void __paginginit free_area_init_node(int nid, unsigned long *zones_size, + pg_data_t *pgdat = NODE_DATA(nid); + + /* pg_data_t should be reset to zero when it's allocated */ +- WARN_ON(pgdat->nr_zones || pgdat->node_start_pfn || pgdat->classzone_idx); ++ WARN_ON(pgdat->nr_zones || pgdat->classzone_idx); + + pgdat->node_id = nid; + pgdat->node_start_pfn = node_start_pfn; +-- +1.7.9.5 + + +> +> -- +> Regards/Gruss, +> Boris. +> +> Advanced Micro Devices GmbH +> Einsteinring 24, 85609 Dornach +> GM: Alberto Bozzo +> Reg: Dornach, Landkreis Muenchen +> HRB Nr. 43632 WEEE Registernr: 129 19551 +> +> -- +> To unsubscribe, send a message with 'unsubscribe linux-mm' in +> the body to majordomo@kvack.org. For more info on Linux MM, +> see: http://www.linux-mm.org/ . +> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> + +-- +Kind regards, +Minchan Kim diff --git a/a/content_digest b/N1/content_digest index ae80724..bb5d626 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -127,6 +127,70 @@ "I am not sure I send this patch to whom, Linus or Andrew?\n" "Anyway, Please use below if really need it.\n" "\n" - Thanks! + "Thanks!\n" + "\n" + ">From b575b78a1ba7daf7a9adc3b49dadfbd573be398d Mon Sep 17 00:00:00 2001\n" + "From: Minchan Kim <minchan@kernel.org>\n" + "Date: Mon, 6 Aug 2012 08:57:57 +0900\n" + "Subject: [PATCH] mm: fix wrong warning check for detect pgdat's garbage\n" + "\n" + "[1] added some check for pgdat garbage but Borislav reported\n" + "the warning happens in 4-node AMD system.\n" + "\n" + "The problem is that node_start_pfn is initialized doublely\n" + "in arch code and generic mm code. Normally, pgdat's members\n" + "are closely related to arch boot code so it's not good idea\n" + "to check such members in generic mm code.\n" + "\n" + "So this patch removes node_start_pfn check and leave other\n" + "variable check as it is because nr_zone and classzone_idx\n" + "should be initialized by generic mm code, NOT arch code so\n" + "it would never happen problem.\n" + "\n" + "[1] 88fdf75d, mm: warn if pg_data_t isn't initialized with zero\n" + "\n" + "Reporeted-by: Borislav Petkov <bp@amd64.org>\n" + "Signed-off-by: Minchan Kim <minchan@kernel.org>\n" + "---\n" + " mm/page_alloc.c | 2 +-\n" + " 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "\n" + "diff --git a/mm/page_alloc.c b/mm/page_alloc.c\n" + "index 889532b..009ac28 100644\n" + "--- a/mm/page_alloc.c\n" + "+++ b/mm/page_alloc.c\n" + "@@ -4511,7 +4511,7 @@ void __paginginit free_area_init_node(int nid, unsigned long *zones_size,\n" + " \tpg_data_t *pgdat = NODE_DATA(nid);\n" + " \n" + " \t/* pg_data_t should be reset to zero when it's allocated */\n" + "-\tWARN_ON(pgdat->nr_zones || pgdat->node_start_pfn || pgdat->classzone_idx);\n" + "+\tWARN_ON(pgdat->nr_zones || pgdat->classzone_idx);\n" + " \n" + " \tpgdat->node_id = nid;\n" + " \tpgdat->node_start_pfn = node_start_pfn;\n" + "-- \n" + "1.7.9.5\n" + "\n" + "\n" + "> \n" + "> -- \n" + "> Regards/Gruss,\n" + "> Boris.\n" + "> \n" + "> Advanced Micro Devices GmbH\n" + "> Einsteinring 24, 85609 Dornach\n" + "> GM: Alberto Bozzo\n" + "> Reg: Dornach, Landkreis Muenchen\n" + "> HRB Nr. 43632 WEEE Registernr: 129 19551\n" + "> \n" + "> --\n" + "> To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "> the body to majordomo@kvack.org. For more info on Linux MM,\n" + "> see: http://www.linux-mm.org/ .\n" + "> Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>\n" + "\n" + "-- \n" + "Kind regards,\n" + Minchan Kim -50635b107c2f57464bc1106af01abe415a1931b2dcf2b6439024599a75ab86c1 +71dcc2efcec1df694a73c4edc47ca8c1f1f633bfed979178d742ebd9757e440d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.