From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] GPIO: gpio-pxa: simplify pxa_gpio_to_irq() and pxa_irq_to_chip()
Date: Mon, 6 Aug 2012 10:26:08 +0000 [thread overview]
Message-ID: <201208061026.08928.arnd@arndb.de> (raw)
In-Reply-To: <501F9799.5020400@compulab.co.il>
On Monday 06 August 2012, Igor Grinberg wrote:
> I see. Ok then. I'm not a huge fan of having the #ifdes inside
> the code (functions) and thinking of moving those outside of the function,
> I get pretty much the same solution it was before your patch.
>
> I really think that PXA|MMP_GPIO_TO_IRQ should be moved to some common
> location (say arch/arm/plat-pxa/) so both are available regardless
> of CONFIG_ARCH_MMP|PXA. That will simplify the code even more.
> But probably it is too much to ask for that simple patch...
> So, I'm fine with the patch.
Right. I would also not try to spend too much work on making pxa and
mmp coexist better when the plan is to merge them eventually. At that
point, a couple of these hacks can just be removed.
Arnd
prev parent reply other threads:[~2012-08-06 10:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 15:35 [PATCH 1/2] GPIO: gpio-pxa: simplify pxa_gpio_to_irq() and pxa_irq_to_chip() Daniel Mack
2012-07-25 15:35 ` [PATCH 2/2] GPIO: gpio-pxa: fix devicetree functions Daniel Mack
2012-08-04 23:16 ` Linus Walleij
2012-08-05 3:52 ` Haojian Zhuang
2012-08-05 9:40 ` Linus Walleij
2012-08-05 12:58 ` Haojian Zhuang
2012-07-25 16:17 ` [PATCH 1/2] GPIO: gpio-pxa: simplify pxa_gpio_to_irq() and pxa_irq_to_chip() Arnd Bergmann
2012-07-25 18:11 ` Daniel Mack
2012-07-25 19:10 ` Arnd Bergmann
2012-08-04 23:20 ` Linus Walleij
2012-08-05 8:31 ` Igor Grinberg
2012-08-05 11:56 ` Daniel Mack
2012-08-06 10:08 ` Igor Grinberg
2012-08-06 10:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201208061026.08928.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.