From: Frederic Weisbecker <fweisbec@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Ahern <dsahern@gmail.com>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Namhyung Kim <namhyung@gmail.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/2] perf tools: Support for events bash completion
Date: Tue, 7 Aug 2012 18:05:11 +0200 [thread overview]
Message-ID: <20120807160447.GE12858@somewhere.redhat.com> (raw)
In-Reply-To: <20120807170504.35646bf8@pyramind.ukuu.org.uk>
On Tue, Aug 07, 2012 at 05:05:04PM +0100, Alan Cox wrote:
> > > COMPREPLY=( $( compgen -W '$cmds' -- "$cur" ) )
> > > + # List possible events for -e option
> > > + elif [[ $prev == "-e" && "${COMP_WORDS[1]}" == @(record|stat|top) ]]; then
> > > + cmds=$(perf list --raw-dump)
> > > + COMPREPLY=( $( compgen -W '$cmds' -- $cur ) )
>
>
> Surely $cur should be quoted here...
Right, fixing that too.
thanks.
> Alan
next prev parent reply other threads:[~2012-08-07 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 13:19 [PATCH 0/2] perf tools: Basic bash completion support Frederic Weisbecker
2012-08-07 13:19 ` [PATCH 1/2] perf tools: Initial " Frederic Weisbecker
2012-08-07 14:11 ` David Ahern
2012-08-07 15:53 ` Frederic Weisbecker
2012-08-07 13:19 ` [PATCH 2/2] perf tools: Support for events bash completion Frederic Weisbecker
2012-08-07 14:48 ` David Ahern
2012-08-07 15:50 ` Frederic Weisbecker
2012-08-07 16:05 ` Alan Cox
2012-08-07 16:05 ` Frederic Weisbecker [this message]
2012-08-07 13:22 ` [PATCH 0/2] perf tools: Basic bash completion support Frederic Weisbecker
2012-08-07 14:18 ` David Ahern
2012-08-07 15:45 ` Frederic Weisbecker
2012-08-07 15:59 ` David Ahern
-- strict thread matches above, loose matches on Subject: below --
2012-08-07 16:59 [PATCH 0/2] perf tools: Basic bash completion support v2 Frederic Weisbecker
2012-08-07 17:00 ` [PATCH 2/2] perf tools: Support for events bash completion Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807160447.GE12858@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.