All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prakash Surya <surya1@llnl.gov>
To: lustre-devel@lists.lustre.org
Subject: [Lustre-devel] merges to b2_<x>
Date: Tue, 7 Aug 2012 09:08:54 -0700	[thread overview]
Message-ID: <20120807160854.GL6857@llnl.gov> (raw)
In-Reply-To: <50209FD0.8000306@cray.com>

Looking at the man page for git-cherry-pick, I'm not sure the "-x"
option would entirely work:

    "Append the note only for cherry picks without conflicts."

How often do the backported patches apply without conflicts? With the
amount of code change taking place, my guess is conflicts are normal
operation. A developer enforced convention detailing the commit
backported and perhaps what and why changes were necessary to apply
cleanly would suffice. So long as it doesn't clutter the commit message.

Another way to do this would be to use the same Change-Id field for the
backported patch. One could grep for the Change-Id in the commit logs
relatively easily, although I'm not sure how the review system would
handle this.

-- 
Cheers, Prakash

On Mon, Aug 06, 2012 at 09:55:44PM -0700, Cory Spitz wrote:
> Hi.
> 
> We at Cray have been looking at b2_1 landings, and one thing that I 
> think would be nice is if we could identify the master commit that the 
> b2_1 commit is based on directly from the mod header.  Unless, of 
> course, there is an easy way to derive this information via git.  I hope 
> that this isn't a stupid question, but is there?  It seems to me that 
> since most b2_1 commits are cherry picked that we lose that bit.  It 
> seems that git cherry-pick -x might be useful here.  Is that all we need?
> 
> If there isn't an easy way for git to provide the lineage, would we be 
> able to add an additional commit tag or just advertise a convention to 
> follow at http://wiki.whamcloud.com/display/PUB/Commit+Comments?
> 
> Thanks,
> -Cory
> _______________________________________________
> Lustre-devel mailing list
> Lustre-devel at lists.lustre.org
> http://lists.lustre.org/mailman/listinfo/lustre-devel

  reply	other threads:[~2012-08-07 16:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-07  4:55 [Lustre-devel] merges to b2_<x> Cory Spitz
2012-08-07 16:08 ` Prakash Surya [this message]
2012-08-07 19:45   ` [Lustre-devel] [lustre-devel] " Andreas Dilger
2012-08-07 21:00     ` Bruce Korb
2012-10-05  3:04 ` [Lustre-devel] " Oleg Drokin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120807160854.GL6857@llnl.gov \
    --to=surya1@llnl.gov \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.