From: Josef Bacik <jbacik@fusionio.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [josef-btrfs:master 12/16] fs/btrfs/inode.c:78:19: sparse: symbol 'btrfs_dip_cachep' was not dec
Date: Tue, 07 Aug 2012 16:58:06 +0000 [thread overview]
Message-ID: <20120807165806.GC2141@localhost.localdomain> (raw)
In-Reply-To: <20120807162015.GA10779@localhost>
On Tue, Aug 07, 2012 at 10:20:15AM -0600, Fengguang Wu wrote:
> Hi Josef,
>
> FYI, there are new sparse warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master
> head: 1529b67c68e0ac3123a831815c26211d801ab975
> commit: 3f1d28fc7d56b5b6c77af4ca1f258dacdd508ce4 [12/16] Btrfs: use a slab for btrfs_dio_private
>
> All sparse warnings:
>
> + fs/btrfs/inode.c:78:19: sparse: symbol 'btrfs_dip_cachep' was not declared. Should it be static?
>
> vim +78 fs/btrfs/inode.c
> 75 struct kmem_cache *btrfs_transaction_cachep;
> 76 struct kmem_cache *btrfs_path_cachep;
> 77 struct kmem_cache *btrfs_free_space_cachep;
> > 78 struct kmem_cache *btrfs_dip_cachep;
> 79
> 80 #define S_SHIFT 12
> 81 static unsigned char btrfs_type_by_mode[S_IFMT >> S_SHIFT] = {
>
> Please consider folding the attached diff :-)
>
Folded in, thanks!
Josef
prev parent reply other threads:[~2012-08-07 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 16:20 [josef-btrfs:master 12/16] fs/btrfs/inode.c:78:19: sparse: symbol 'btrfs_dip_cachep' was not declare Fengguang Wu
2012-08-07 16:58 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120807165806.GC2141@localhost.localdomain \
--to=jbacik@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.