From: Thierry Reding <thierry.reding@avionic-design.de>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: 'Tushar Behera' <tushar.behera@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
s.hauer@pengutronix.de, patches@linaro.org,
'Jingoo Han' <jg1.han@samsung.com>
Subject: Re: [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig
Date: Wed, 8 Aug 2012 13:39:35 +0200 [thread overview]
Message-ID: <20120808113935.GA20963@avionic-0098.mockup.avionic-design.de> (raw)
In-Reply-To: <0af001cd7550$1af66040$50e320c0$%kim@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]
On Wed, Aug 08, 2012 at 07:25:17PM +0900, Kukjin Kim wrote:
> So, how about following? If PWM is selected on Samsung SoCs, the PWM_SAMSUNG
> will be selected automatically. Of course, it can be de-selected in kernel
> menuconfig. Note that, I think, using 'bool <expr>' and 'depends on <expr>'
> is more clear than 'prompt <prompt> ["if" <expr>]'. However if any your
> preference here, please kindly let me know.
>
> ---
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 8fc3808..c74d055 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -58,14 +58,12 @@ config PWM_PXA
> will be called pwm-pxa.
>
> config PWM_SAMSUNG
> - tristate "Samsung pwm support"
> + bool "Samsung PWM support"
> depends on PLAT_SAMSUNG
> + default y
> help
> Generic PWM framework driver for Samsung.
>
> - To compile this driver as a module, choose M here: the module
> - will be called pwm-samsung.
> -
> config PWM_TEGRA
> tristate "NVIDIA Tegra PWM support"
> depends on ARCH_TEGRA
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-08 11:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 9:59 [PATCH] ARM: SAMSUNG: Fix compilation error with s3c2410_defconfig Tushar Behera
2012-08-07 10:33 ` Kukjin Kim
2012-08-07 11:00 ` Tushar Behera
2012-08-08 0:54 ` Kukjin Kim
2012-08-08 6:11 ` Thierry Reding
2012-08-08 6:30 ` Kukjin Kim
2012-08-08 6:50 ` Thierry Reding
2012-08-08 10:25 ` Kukjin Kim
2012-08-08 11:07 ` Thierry Reding
2012-08-08 11:36 ` Kukjin Kim
2012-08-08 11:39 ` Thierry Reding [this message]
2012-08-08 1:32 ` Kukjin Kim
2012-08-08 2:58 ` Tushar Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808113935.GA20963@avionic-0098.mockup.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.