From: Pavel Roskin <proski@gnu.org>
To: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] ath9k: decrypt_error flag issue
Date: Wed, 8 Aug 2012 16:48:13 -0400 [thread overview]
Message-ID: <20120808164813.0011148e@mj> (raw)
In-Reply-To: <CAA2SeNLv9pE_3_-99Df_s0gF+56O6TFjfDfV-QuVxsOc6_Z5TQ@mail.gmail.com>
On Wed, 8 Aug 2012 19:20:15 +0200
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com> wrote:
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
> ---
Please see Documentation/SubmittingPatches in Linux sources. In
particular, you separated the description of the patch from its
contents. Single patch doesn't need to be send as series. The
description for the series is not a substitute for a description of
every patch.
Also, the subject should summarize the patch. I know, it may be hard
to fit, but not impossible.
When exactly would you have the problem that decrypt_error is not
unset, but should be? It's important that you show your assumptions so
that others can see if they are correct, in addition to checking the
code. Other developers are more likely to check your patch if you
show understanding of the code you have changed.
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -1780,7 +1780,6 @@
That's weird, recv.c is 1273 lines long in wireless-testing.git.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2012-08-08 20:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 17:20 [PATCH 1/1] ath9k: decrypt_error flag issue Lorenzo Bianconi
2012-08-08 20:48 ` Pavel Roskin [this message]
2012-08-09 12:27 ` Lorenzo Bianconi
2012-08-09 12:51 ` Mohammed Shafi
2012-08-09 20:48 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808164813.0011148e@mj \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.