From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: manish.rangankar@qlogic.com, open-iscsi@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [SCSI] qla4xxx: support iscsiadm session mgmt
Date: Wed, 8 Aug 2012 19:57:12 +0300 [thread overview]
Message-ID: <20120808165712.GB3734@mwanda> (raw)
In-Reply-To: <50228750.3030108@cs.wisc.edu>
On Wed, Aug 08, 2012 at 10:35:44AM -0500, Mike Christie wrote:
> On 08/08/2012 10:00 AM, Dan Carpenter wrote:
> > I never heard back on this. This buffer overflow is still present
> > in the current code.
> >
>
> Qlogic just sent a patch yesterday.
> http://marc.info/?l=linux-scsi&m=134434199930938&w=2
Ah, good.
It seems like qla4xxx_ep_connect() should take a pointer to struct
sockaddr_storage and also dst_addr in qla4xxx_get_ep_fwdb() should
be changed as well. As in:
static struct iscsi_endpoint *
-qla4xxx_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
+qla4xxx_ep_connect(struct Scsi_Host *shost, struct sockaddr_storage *dst_addr,
int non_blocking)
regards,
dan carpenter
next prev parent reply other threads:[~2012-08-08 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 18:27 [SCSI] qla4xxx: support iscsiadm session mgmt Dan Carpenter
2012-08-08 15:00 ` Dan Carpenter
2012-08-08 15:35 ` Mike Christie
2012-08-08 16:57 ` Dan Carpenter [this message]
2012-08-09 17:49 ` Michael Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808165712.GB3734@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.rangankar@qlogic.com \
--cc=michaelc@cs.wisc.edu \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.