All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: linux-input@vger.kernel.org
Subject: Re: HID: hid-multitouch: Switch to device groups
Date: Wed, 8 Aug 2012 21:07:58 +0300	[thread overview]
Message-ID: <20120808180758.GC3734@mwanda> (raw)
In-Reply-To: <20120808172829.GA1001@polaris.bitmath.org>

On Wed, Aug 08, 2012 at 07:28:29PM +0200, Henrik Rydberg wrote:
> Hi Dan,
> 
> > This is a semi-automatic email about new static checker warnings.
> > 
> > The patch 4fa3a5837b84: "HID: hid-multitouch: Switch to device 
> > groups" from May 1, 2012, leads to the following Smatch complaint:
> > 
> > drivers/hid/hid-multitouch.c:735 mt_probe()
> > 	 error: we previously assumed 'id' could be null (see line 694)
> 
> Yes, and the same patch also removes the reason 'id' could be null.

Great.  Could you remove the unneeded check in mt_probe() and give
me a Reported-by: tag?

regards,
dan carpenter


  reply	other threads:[~2012-08-08 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-08 13:44 HID: hid-multitouch: Switch to device groups Dan Carpenter
2012-08-08 17:28 ` Henrik Rydberg
2012-08-08 18:07   ` Dan Carpenter [this message]
2012-08-08 19:54     ` Henrik Rydberg
2012-08-15  8:38       ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120808180758.GC3734@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=linux-input@vger.kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.