From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Wed, 08 Aug 2012 19:17:18 +0000 Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Message-Id: <201208081917.19111.arnd@arndb.de> List-Id: References: <1344389967-8465-1-git-send-email-linux@prisktech.co.nz> <1344389967-8465-9-git-send-email-linux@prisktech.co.nz> <5022B242.1050001@wwwdotorg.org> In-Reply-To: <5022B242.1050001@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wednesday 08 August 2012, Stephen Warren wrote: > I think that's all just: > > module_platform_driver(vt8500_gpio_driver); > > (except that _init uses platform_driver_probe() rather than > platform_driver_register(), which seems unusual. I guess that explains > the of_find_matching_node() above too.) Ah, I totally missed both of these. Using platform_driver_register is definitely preferred over platform_driver_probe in cases like this, so using module_platform_driver is the right simplification. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Date: Wed, 8 Aug 2012 19:17:18 +0000 Message-ID: <201208081917.19111.arnd@arndb.de> References: <1344389967-8465-1-git-send-email-linux@prisktech.co.nz> <1344389967-8465-9-git-send-email-linux@prisktech.co.nz> <5022B242.1050001@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5022B242.1050001-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Stephen Warren Cc: linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, vt8500-wm8505-linux-kernel-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Russell King , Florian Tobias Schandinat , Alan Stern , Eric Andersson , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Hauke Mehrtens , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Rob Herring , Stephen Warren , Neil Zhang , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Alan Cox , Alessandro Zummo , Linus Walleij , Greg Kroah-Hartman , Mark Brown , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Felipe Balbi List-Id: linux-serial@vger.kernel.org On Wednesday 08 August 2012, Stephen Warren wrote: > I think that's all just: > > module_platform_driver(vt8500_gpio_driver); > > (except that _init uses platform_driver_probe() rather than > platform_driver_register(), which seems unusual. I guess that explains > the of_find_matching_node() above too.) Ah, I totally missed both of these. Using platform_driver_register is definitely preferred over platform_driver_probe in cases like this, so using module_platform_driver is the right simplification. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 8 Aug 2012 19:17:18 +0000 Subject: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 In-Reply-To: <5022B242.1050001@wwwdotorg.org> References: <1344389967-8465-1-git-send-email-linux@prisktech.co.nz> <1344389967-8465-9-git-send-email-linux@prisktech.co.nz> <5022B242.1050001@wwwdotorg.org> Message-ID: <201208081917.19111.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 08 August 2012, Stephen Warren wrote: > I think that's all just: > > module_platform_driver(vt8500_gpio_driver); > > (except that _init uses platform_driver_probe() rather than > platform_driver_register(), which seems unusual. I guess that explains > the of_find_matching_node() above too.) Ah, I totally missed both of these. Using platform_driver_register is definitely preferred over platform_driver_probe in cases like this, so using module_platform_driver is the right simplification. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759137Ab2HHTSG (ORCPT ); Wed, 8 Aug 2012 15:18:06 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:59583 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758860Ab2HHTSB (ORCPT ); Wed, 8 Aug 2012 15:18:01 -0400 From: Arnd Bergmann To: Stephen Warren Subject: Re: [PATCH 8/8] ARM: vt8500: gpio: Devicetree support for arch-vt8500 Date: Wed, 8 Aug 2012 19:17:18 +0000 User-Agent: KMail/1.12.2 (Linux/3.5.0; KDE/4.3.2; x86_64; ; ) Cc: Tony Prisk , vt8500-wm8505-linux-kernel@googlegroups.com, Russell King , Alessandro Zummo , Grant Likely , Rob Herring , Alan Cox , "Greg Kroah-Hartman" , Alan Stern , Hauke Mehrtens , Felipe Balbi , Neil Zhang , Florian Tobias Schandinat , Rob Landley , Mark Brown , Stephen Warren , Eric Andersson , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, rtc-linux@googlegroups.com, devicetree-discuss@lists.ozlabs.org References: <1344389967-8465-1-git-send-email-linux@prisktech.co.nz> <1344389967-8465-9-git-send-email-linux@prisktech.co.nz> <5022B242.1050001@wwwdotorg.org> In-Reply-To: <5022B242.1050001@wwwdotorg.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201208081917.19111.arnd@arndb.de> X-Provags-ID: V02:K0:es0C/1cOnza2PLHbJC7akKIgWnNvjnyZhJbqyQAxuFN Bl+pH9Cl4gdOQ8thIl98eHPJLZBjbSBunBMyTmv8TzcxllOLGo Vrk1Igl5lm2TAOYh+wLQStDIZy98+oyIU9XfSx++3dv4iZcHb7 tvvaOVfvQ5IqK943KT3oBm389SUr0sFqsCTlLlBeFEpGz//sic jGnB0c6NcnWnOUq3HmxyCJ+/zyi7d29UGYNaxOe2rYmScH1DbO orhLlWzkY4Mk/S+db0wzjJWwioKONfK8gLYw5koCm4wOOHrPeF zQRJxIkCzfEJVLNXVVPu2Ec4bgeewc+zbBbD2vd9qtSjgtKOu9 0vl3KI/WAfj++6yZgbg4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 08 August 2012, Stephen Warren wrote: > I think that's all just: > > module_platform_driver(vt8500_gpio_driver); > > (except that _init uses platform_driver_probe() rather than > platform_driver_register(), which seems unusual. I guess that explains > the of_find_matching_node() above too.) Ah, I totally missed both of these. Using platform_driver_register is definitely preferred over platform_driver_probe in cases like this, so using module_platform_driver is the right simplification. Arnd