Re: [PATCH] ARM: EXYNOS: Use generic pwm driver in Origen board

[Thierry Reding <thierry.reding@avionic-design.de>]

[-- Attachment #1: Type: text/plain, Size: 1111 bytes --]

On Thu, Aug 09, 2012 at 02:33:55PM +0530, Tushar Behera wrote:
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  arch/arm/mach-exynos/mach-origen.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/mach-origen.c b/arch/arm/mach-exynos/mach-origen.c
> index 5ca8030..4c4048d 100644
> --- a/arch/arm/mach-exynos/mach-origen.c
> +++ b/arch/arm/mach-exynos/mach-origen.c
[...]
> @@ -613,6 +614,10 @@ static struct platform_device origen_lcd_hv070wsa = {
>  	.dev.platform_data	= &origen_lcd_hv070wsa_data,
>  };
>  
> +static struct pwm_lookup origen_pwm_lookup[] = {
> +	PWM_LOOKUP("s3c24xx-pwm.0", 0, "pwm-backlight.0", NULL),
> +};
> +

This might conflict with some other patches that Jingoo (Cc'ed) is
working on. His patches were going to rework the Samsung PWM driver to
register multiple PWM devices per chip. In that case the s3c24xx-pwm
device should probably be modified to use .id = -1 and then the .0 can
be dropped from the provider name above.

Otherwise this patch looks good to me.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]